Garub 6 Posted June 19, 2018 Share Posted June 19, 2018 Even putting revenge at the top of the priority, sometimes it is not executed, even if it is available. Who could help me? Warrior_Prot_xxx.xml 21 mai 2018 13H34.log.html Link to comment Share on other sites More sharing options...
skeletonboy360 5 Posted June 20, 2018 Share Posted June 20, 2018 Every other spell needs something like “IsUsableSpell>Revenge>False” then it will only use revenge when it is available Link to comment Share on other sites More sharing options...
Garub 6 Posted June 20, 2018 Author Share Posted June 20, 2018 1 hour ago, skeletonboy360 said: Todos os outros feitiços precisam de algo como "IsUsableSpell> Revenge> False", então ele só usará vingança quando estiver disponível Thus? Do I have to do this on all abilities? Link to comment Share on other sites More sharing options...
skeletonboy360 5 Posted June 20, 2018 Share Posted June 20, 2018 Something like that. I'm not sure if Is Spell Usable works for revenge, but thats the basic idea. Yes its tedious, but until you figure out how to make a c# profile, thats what you have to do. Link to comment Share on other sites More sharing options...
Garub 6 Posted June 20, 2018 Author Share Posted June 20, 2018 35 minutes ago, skeletonboy360 said: Algo parecido. Eu não tenho certeza se o Spell Usable trabalha por vingança, mas essa é a idéia básica. Sim, é entediante, mas até você descobrir como fazer um perfil, é isso que você tem que fazer. Thanks, if anyone else who plays with warrior knows I would be super grateful. Link to comment Share on other sites More sharing options...
Garub 6 Posted June 20, 2018 Author Share Posted June 20, 2018 1 hour ago, skeletonboy360 said: Something like that. I'm not sure if Is Spell Usable works for revenge, but thats the basic idea. Yes its tedious, but until you figure out how to make a c# profile, thats what you have to do. I did the tests and found that it does not work, all the skills that inserted the rule "IsUsableSpell> Revenge> False" were not used.@Ordush, @Droidz give hints? Link to comment Share on other sites More sharing options...
Ordush 184 Posted June 20, 2018 Share Posted June 20, 2018 (edited) If you are on vanilla, you need to have the spell on actionbar for IsUsableSpell to work. you can also do a lua condition instead with revengeUsable = IsUsableSpell("Revenge"); revengeUsable has to be your check var however, this is also requires your spell to be on the actionbar. Now, if it make take WRobot a second to register that Revenge is usable, hence it might cast spells anyway. Try increasing the fps on the FC. (Top left corner). Edit: I just noticed devastate, so you are not on Vanilla. ? Edited June 20, 2018 by Ordush Link to comment Share on other sites More sharing options...
Garub 6 Posted June 20, 2018 Author Share Posted June 20, 2018 6 hours ago, Ordush said: If you are on vanilla, you need to have the spell on actionbar for IsUsableSpell to work. you can also do a lua condition instead with revengeUsable = IsUsableSpell("Revenge"); revengeUsable has to be your check var however, this is also requires your spell to be on the actionbar. Now, if it make take WRobot a second to register that Revenge is usable, hence it might cast spells anyway. Try increasing the fps on the FC. (Top left corner). Edit: I just noticed devastate, so you are not on Vanilla. ? I'm in version 3.3.5 ------------------------------------------------------------------------------------ Lua Script: Lua Script CastSpellByName("Revenge");retV=1; Return value research 0 Return value var retV ------------------------------------------------------------------------------------ If I put this code to revenge, does it work? I used this code for the Heroic striker I do not know how this code works, but after I used Heroic Strike it worked correctly. Link to comment Share on other sites More sharing options...
Ordush 184 Posted June 20, 2018 Share Posted June 20, 2018 (edited) 54 minutes ago, Garub said: I'm in version 3.3.5 ------------------------------------------------------------------------------------ Lua Script: Lua Script CastSpellByName("Revenge");retV=1; Return value research 0 Return value var retV ------------------------------------------------------------------------------------ If I put this code to revenge, does it work? I used this code for the Heroic striker I do not know how this code works, but after I used Heroic Strike it worked correctly. That works? ? It just sets retV to 1, so it'll never be true? ? Lua Script: revengeUsable = IsUsableSpell("Revenge"); Return value research false Return value var revengeUsable The code you wrote above just casts Heroic Strike. This is why your revenge is not prioritized. Every time it gets to Heroic Strike, it will run the code you just wrote, and cast heroic strike, it will overwrite any condition you have made. Edit: Just looked through your code. The heroic strike will always overwrite anything, it does not care for any conditions at all. My guess is that you made that code in or for it to not turn OFF heroic strike Instead do it like this: Where it says "Heroic Strike" on the left (spell name) write: RunMacroText("/cast !Heroic Strike") Then under the spell settings (top setings thingy) change to Is Lua Code or whatever it says. ? Then remove that silly LuaScript. ? Edited June 20, 2018 by Ordush Link to comment Share on other sites More sharing options...
Garub 6 Posted June 21, 2018 Author Share Posted June 21, 2018 5 hours ago, Ordush said: That works? ? It just sets retV to 1, so it'll never be true? ? Lua Script: revengeUsable = IsUsableSpell("Revenge"); Return value research false Return value var revengeUsable The code you wrote above just casts Heroic Strike. This is why your revenge is not prioritized. Every time it gets to Heroic Strike, it will run the code you just wrote, and cast heroic strike, it will overwrite any condition you have made. Edit: Just looked through your code. The heroic strike will always overwrite anything, it does not care for any conditions at all. My guess is that you made that code in or for it to not turn OFF heroic strike Instead do it like this: Where it says "Heroic Strike" on the left (spell name) write: RunMacroText("/cast !Heroic Strike") Then under the spell settings (top setings thingy) change to Is Lua Code or whatever it says. ? Then remove that silly LuaScript. ? in fact I write this code in Heroic Strike because when it was activated Wrobot waited for his execution to initiate the other abilities, so I stayed a few seconds without attacking Heroic Strike and always in the next attack, understood (sorry my English I'm using the google translation) I'm brazilian. Even with these new information, do you recommend that I change my Heroic Strike code to the one you wrote? Link to comment Share on other sites More sharing options...
Ordush 184 Posted June 21, 2018 Share Posted June 21, 2018 7 hours ago, Garub said: in fact I write this code in Heroic Strike because when it was activated Wrobot waited for his execution to initiate the other abilities, so I stayed a few seconds without attacking Heroic Strike and always in the next attack, understood (sorry my English I'm using the google translation) I'm brazilian. Even with these new information, do you recommend that I change my Heroic Strike code to the one you wrote? If you don't change your code all your conditions will be irrelevant. Link to comment Share on other sites More sharing options...
Garub 6 Posted June 21, 2018 Author Share Posted June 21, 2018 18 minutes ago, Ordush said: If you don't change your code all your conditions will be irrelevant. Please correct me if I'm wrong. Link to comment Share on other sites More sharing options...
Marsbar 227 Posted June 21, 2018 Share Posted June 21, 2018 In the picture of your screen (lol) it looks like you have RunMacroText("/cast! Heroic Strike") instead you should have RunMacroText("/cast !Heroic Strike") like Ordush posted above. Link to comment Share on other sites More sharing options...
Matenia 620 Posted June 21, 2018 Share Posted June 21, 2018 Also it should be "Not spell, is Lua script", the other part is Lua code for the bot (so for example, using Lua to access the objectmanager etc). Link to comment Share on other sites More sharing options...
Ordush 184 Posted June 21, 2018 Share Posted June 21, 2018 Also, you don't want to remove all your conditions, they should still be there. Only remove your Lua Script condition. ? Link to comment Share on other sites More sharing options...
Garub 6 Posted June 21, 2018 Author Share Posted June 21, 2018 lol, now I'm feeling dumber than normal. kkkkkkkk, sorry guys, I'm super amateur in codes and programming, not to mention my inability to understand English. Ok, here's another impression of how the FC was that you guided me. 4 hours ago, Matenia said: Also it should be "Not spell, is Lua script", the other part is Lua code for the bot (so for example, using Lua to access the objectmanager etc). I just do not understand that part, what should I put there? -------------------------------------------------------------------------- I put my combat routine in case any of you want to do the correction directly ^^. Warrior_Prot_forum.xml Link to comment Share on other sites More sharing options...
Ordush 184 Posted June 21, 2018 Share Posted June 21, 2018 11 minutes ago, Garub said: lol, now I'm feeling dumber than normal. kkkkkkkk, sorry guys, I'm super amateur in codes and programming, not to mention my inability to understand English. Ok, here's another impression of how the FC was that you guided me. I just do not understand that part, what should I put there? -------------------------------------------------------------------------- I put my combat routine in case any of you want to do the correction directly ^^. Warrior_Prot_forum.xml look at what Matenia wrote. ? Where it says "Not spell, is lua script" set that to true. ? Link to comment Share on other sites More sharing options...
Garub 6 Posted June 21, 2018 Author Share Posted June 21, 2018 4 minutes ago, Ordush said: look at what Matenia wrote. ? Where it says "Not spell, is lua script" set that to true. ? Doing this I finish? Link to comment Share on other sites More sharing options...
Ordush 184 Posted June 21, 2018 Share Posted June 21, 2018 Just now, Garub said: Doing this I finish? Yes, remember to change both your instances of Heroic Strike. ? Link to comment Share on other sites More sharing options...
Garub 6 Posted June 21, 2018 Author Share Posted June 21, 2018 1 minute ago, Ordush said: Yes, remember to change both your instances of Heroic Strike. ? kkkkkkkkk how am I dumb, you refer to combat instance, berserker stance and etc ... Link to comment Share on other sites More sharing options...
Ordush 184 Posted June 21, 2018 Share Posted June 21, 2018 You have 2x Heroics strike, change both of them Garub 1 Link to comment Share on other sites More sharing options...
Garub 6 Posted June 21, 2018 Author Share Posted June 21, 2018 Ok I'm going now, to do the tests, and then come back with the results. Link to comment Share on other sites More sharing options...
Ordush 184 Posted June 21, 2018 Share Posted June 21, 2018 Just now, Garub said: Ok I'm going now, to do the tests, and then come back with the results. IF it does not use revenge before everything else, then add the condition that you were told to, in the very start of this post, to all other spells than revenge. (IsUsable) Link to comment Share on other sites More sharing options...
Garub 6 Posted June 21, 2018 Author Share Posted June 21, 2018 2 minutes ago, Ordush said: IF it does not use revenge before everything else, then add the condition that you were told to, in the very start of this post, to all other spells than revenge. (IsUsable) Okay, I'll do as your orientation. Link to comment Share on other sites More sharing options...
Garub 6 Posted August 15, 2018 Author Share Posted August 15, 2018 @Ordush Ordush my friend, I'm in trouble again and I would like to use his sapiencia in this problem. I made a video to demonstrate what happens with my combat routine, I do not know why, but it takes time to be using Revenge and Shield Slam, even I placing them as high priority. What am I doing wrong? Link video: [F] 21:45:17.168 - [FightClass] Loading Fight class: D:\Games\WOW\BOT\WRobot\teste\\FightClass\Warrior_Prot_xxx_PVE.xml [D] 21:45:17.198 - [Spell] Revenge (Id found: 57823, Name found: Revenge, NameInGame found: Revenge, Know = True, IsSpellUsable = False) [D] 21:45:17.231 - [Spell] Shield Slam (Id found: 47488, Name found: Shield Slam, NameInGame found: Shield Slam, Know = True, IsSpellUsable = False) [D] 21:45:17.232 - [Spell] Shield Slam (Id found: 47488, Name found: Shield Slam, NameInGame found: Shield Slam, Know = True, IsSpellUsable = False) [D] 21:45:17.233 - [Spell] Shield Slam (Id found: 47488, Name found: Shield Slam, NameInGame found: Shield Slam, Know = True, IsSpellUsable = False) [D] 21:45:17.237 - [Spell] Revenge (Id found: 57823, Name found: Revenge, NameInGame found: Revenge, Know = True, IsSpellUsable = False) [D] 21:45:17.238 - [Spell] Revenge (Id found: 57823, Name found: Revenge, NameInGame found: Revenge, Know = True, IsSpellUsable = False) [D] 21:45:17.239 - [Spell] Shield Slam (Id found: 47488, Name found: Shield Slam, NameInGame found: Shield Slam, Know = True, IsSpellUsable = False) [D] 21:45:17.241 - [Spell] Shield Slam (Id found: 47488, Name found: Shield Slam, NameInGame found: Shield Slam, Know = True, IsSpellUsable = False) [D] 21:45:17.242 - [Spell] Revenge (Id found: 57823, Name found: Revenge, NameInGame found: Revenge, Know = True, IsSpellUsable = False) [D] 21:45:17.243 - [Spell] Revenge (Id found: 57823, Name found: Revenge, NameInGame found: Revenge, Know = True, IsSpellUsable = False) [D] 21:45:17.244 - [Spell] Revenge (Id found: 57823, Name found: Revenge, NameInGame found: Revenge, Know = True, IsSpellUsable = False) [D] 21:45:17.245 - [Spell] Revenge (Id found: 57823, Name found: Revenge, NameInGame found: Revenge, Know = True, IsSpellUsable = False) [D] 21:45:17.975 - [Spell] Shield Slam (Id found: 47488, Name found: Shield Slam, NameInGame found: Shield Slam, Know = True, IsSpellUsable = False) [D] 21:45:18.007 - [Spell] Revenge (Id found: 57823, Name found: Revenge, NameInGame found: Revenge, Know = True, IsSpellUsable = False) [D] 21:45:18.040 - [Spell] Heroic Throw (Id found: 57755, Name found: Heroic Throw, NameInGame found: Heroic Throw, Know = True, IsSpellUsable = True) [D] 21:45:18.076 - [Spell] Shield Block (Id found: 2565, Name found: Shield Block, NameInGame found: Shield Block, Know = True, IsSpellUsable = True) [D] 21:45:18.104 - [Spell] Thunder Clap (Id found: 47502, Name found: Thunder Clap, NameInGame found: Thunder Clap, Know = True, IsSpellUsable = False) [D] 21:45:18.138 - [Spell] Concussion Blow (Id found: 12809, Name found: Concussion Blow, NameInGame found: Concussion Blow, Know = True, IsSpellUsable = False) [D] 21:45:18.172 - [Spell] Shockwave (Id found: 46968, Name found: Shockwave, NameInGame found: Shockwave, Know = True, IsSpellUsable = False) [D] 21:45:18.203 - [Spell] Devastate (Id found: 47498, Name found: Devastate, NameInGame found: Devastate, Know = True, IsSpellUsable = False) [D] 21:45:18.236 - [Spell] Rend (Id found: 47465, Name found: Rend, NameInGame found: Rend, Know = True, IsSpellUsable = False) [D] 21:45:18.269 - [Spell] Last Stand (Id found: 12975, Name found: Last Stand, NameInGame found: Last Stand, Know = True, IsSpellUsable = True) [D] 21:45:18.302 - [Spell] Enraged Regeneration (Id found: 55694, Name found: Enraged Regeneration, NameInGame found: Enraged Regeneration, Know = True, IsSpellUsable = False) [D] 21:45:18.334 - [Spell] Bloodrage (Id found: 2687, Name found: Bloodrage, NameInGame found: Bloodrage, Know = True, IsSpellUsable = True) [D] 21:45:18.367 - [Spell] Shield Bash (Id found: 72, Name found: Shield Bash, NameInGame found: Shield Bash, Know = True, IsSpellUsable = False) [D] 21:45:18.398 - [Spell] Shield Wall (Id found: 871, Name found: Shield Wall, NameInGame found: Shield Wall, Know = True, IsSpellUsable = True) [D] 21:45:18.399 - [Spell] Shield Wall (Id found: 871, Name found: Shield Wall, NameInGame found: Shield Wall, Know = True, IsSpellUsable = True) [D] 21:45:18.430 - [Spell] Berserker Rage (Id found: 18499, Name found: Berserker Rage, NameInGame found: Berserker Rage, Know = True, IsSpellUsable = True) [D] 21:45:18.431 - [Spell] Berserker Rage (Id found: 18499, Name found: Berserker Rage, NameInGame found: Berserker Rage, Know = True, IsSpellUsable = True) [D] 21:45:18.464 - [Spell] Commanding Shout (Id found: 47440, Name found: Commanding Shout, NameInGame found: Commanding Shout, Know = True, IsSpellUsable = False) [D] 21:45:18.496 - [Spell] Taunt (Id found: 355, Name found: Taunt, NameInGame found: Taunt, Know = True, IsSpellUsable = True) [D] 21:45:18.528 - [Spell] War Stomp (Id found: 20549, Name found: War Stomp, NameInGame found: War Stomp, Know = True, IsSpellUsable = True) 21:45:41.737 - [Fight] Player Attack Withered Mistress (lvl 60) [F] 21:45:41.900 - [Spell] Cast Heroic Throw (Heroic Throw) [F] 21:45:42.224 - [Spell] Cast Shield Block (Shield Block) [F] 21:45:43.698 - [Spell] Cast Shield Slam (Shield Slam) 21:45:44.992 - [Fight] Player Attack Withered Mistress (lvl 60) [F] 21:45:45.121 - [Spell] Cast Concussion Blow (Concussion Blow) [F] 21:45:45.346 - [Spell] Cast Revenge (Revenge) [F] 21:45:45.702 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:45:46.375 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:45:46.918 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:45:47.495 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:45:48.073 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:45:48.625 - [FightClass] Launch LUA script: RunMacroText("/cast !Heroic Strike") [F] 21:45:49.176 - [FightClass] Launch LUA script: RunMacroText("/cast !Heroic Strike") [F] 21:45:49.750 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") 21:45:51.194 - [Fight] Player Attack Withered Mistress (lvl 60) [F] 21:45:51.261 - [Spell] Cast Shield Slam (Shield Slam) 21:47:04.423 - [Fight] Player Attack Voodoo Slave (lvl 60) [F] 21:47:04.562 - [Spell] Cast Heroic Throw (Heroic Throw) [F] 21:47:05.059 - [Spell] Cast Shield Block (Shield Block) [F] 21:47:05.960 - [Spell] Cast Revenge (Revenge) [F] 21:47:06.205 - [Spell] Cast Shield Slam (Shield Slam) 21:47:06.831 - [Fight] Player Attack Atal'ai Mistress (lvl 60) [F] 21:47:07.031 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:08.148 - [Spell] Cast Concussion Blow (Concussion Blow) [F] 21:47:08.483 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:09.050 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:11.199 - [Spell] Cast Revenge (Revenge) [F] 21:47:11.535 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:12.134 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:12.601 - [Spell] Cast Shield Slam (Shield Slam) [F] 21:47:12.936 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:13.533 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:14.116 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:14.680 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") 21:47:15.100 - [Fight] Player Attack Atal'ai Mistress (lvl 60) [F] 21:47:15.270 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:15.839 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:16.409 - [FightClass] Launch LUA script: RunMacroText("/cast !Heroic Strike") [F] 21:47:16.877 - [Spell] Cast Revenge (Revenge) [F] 21:47:17.222 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:17.788 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:18.371 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:18.835 - [Spell] Cast Shield Slam (Shield Slam) [F] 21:47:19.174 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:19.748 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:20.315 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:20.881 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:21.453 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:22.022 - [FightClass] Launch LUA script: RunMacroText("/cast !Heroic Strike") [F] 21:47:22.496 - [Spell] Cast Revenge (Revenge) 21:47:23.175 - [Fight] Player Attack Withered Mistress (lvl 60) [F] 21:47:23.340 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:23.918 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:24.510 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:25.085 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:25.551 - [Spell] Cast Shield Slam (Shield Slam) [F] 21:47:25.900 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:26.449 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:26.952 - [Spell] Cast Shockwave (Shockwave) [F] 21:47:27.188 - [Spell] Cast Thunder Clap (Thunder Clap) [F] 21:47:27.462 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:28.002 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") [F] 21:47:28.549 - [FightClass] Launch LUA script: RunMacroText("/cast !Heroic Strike") [F] 21:47:29.020 - [Spell] Cast Revenge (Revenge) [F] 21:47:29.276 - [FightClass] Launch LUA script: RunMacroText("/cast !Cleave") Warrior_Prot_xxx_PVE.xml 14 ago 2018 20H05.log.html Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now