Womble

Hey - that won't happen with the bot currently as it is. The main function for detecting whether or not you are behind is quite tempremental and the speed in general won't land you correct stun, interrupt timing and so on.

Error is related to 'Is Behind' here's one screenshot example. It is at this moment my rotation resorts to Hemorrhage.

It started off using backstab from behind to, but as the fight went on it started giving bad readings like this.

It happens on various other fights as well.

See PM.

Fixed already. :)

Here's what I get when I select my profile and click start: -

Right, it just looks like its pointing out an error, guess not.

So, my finished HS is: -

condiok = 0; 
local playerhealth = 100 * UnitHealth("player") / UnitHealthMax("player") 
if UnitPower("player") >= 85 or UnitBuff ("player",GetSpellInfo(122510)) and (playerhealth >= 75) then 
	condiok = 1; 
end 

and my finished Cleave: -

condiok = 0; 
local playerhealth = 100 * UnitHealth("player") / UnitHealthMax("player") 
if (UnitBuff ("player",GetSpellInfo(2565)) and (playerhealth >= 50) and UnitPower("player") >= 30) or UnitBuff ("player",GetSpellInfo(122510)) then
	condiok = 1; 
end

I tried to play around and get '(playerhealth >= 50)' to work - at first I had no luck but then I managed to get it to work. The local playerhealth line basically works out the % of the players health if you do the math so I then attempted to get it to work at certain values.

I assume the code is correct? They both seem to work properly with the AND's / OR's at least.

no, it covers (show) only the if-then-end block

Yea, to show there is an error between that piece of code I think. At least see my previous post, it 'fixes' it.

I think 'UnitBuff("player",GetSpellInfo(122510))' should be 'UnitBuff("player"),GetSpellInfo(122510))' ?

At least the error goes away then.

I put the code you fixed into Notepad++ it shows this: -

I assume the red line form top to bottom indicates an error?

Also, what does 'local threat = UnitDetailedThreatSituation("player", "target")' do?

Hi.

Your code doesn't work: -

condiok = 0; 
local playerhealth = 100 * UnitHealth("player") / UnitHealthMax("player") 
local targethealth = 100 * UnitHealth("target") / UnitHealthMax("target") 
local threat = UnitDetailedThreatSituation("player", "target") 
local start, duration, enabled = GetSpellCooldown(2565) 
if (start + duration - GetTime() > 0 and UnitPower("player") >= 85) or UnitBuff

("player",GetSpellInfo(122510)) or UnitBuff("player",GetSpellInfo(122016)) then 
	condiok = 1; 
end 

but I decided to play around with it and can get it to work: -

condiok = 0;
local playerhealth = 100 * UnitHealth("player") / UnitHealthMax("player")
local targethealth = 100 * UnitHealth("target") / UnitHealthMax("target")
local threat = UnitDetailedThreatSituation("player", "target")
local start, duration, enabled = GetSpellCooldown(2565)
if UnitPower("player") >= 85) or UnitBuffID("player",122510) 
then
condiok = 1;
end

The only difference is I took out 'if (start + duration - GetTime() >0' and then deleted the ')' after the UnitPower check since that closed bracket wasn't needed any more. I also removed the Incite check because I didn't want that in.

It works like this, been watching it carefully.

Out of curiosity though, why doesn't the Shield Block part of your 'HSProt.xml' work, any idea?

These parts: 'local start, duration, enabled = GetSpellCooldown(2565) if (start + duration - GetTime() > 0'

So I could just use the code you provided and it would work?

What about the 'research' and 'var' values?

Can these be left blank?

A lot of things can be improved with multiple conditions outside of lua. Certain things though like refreshing something before it falls off as far as I know needs an lua script or the above example where you want to watch 2 sets of durations and act differently above / below those times.

But yeah, what Droidz says as well, try those.

Let us know how the King Similie one works, sounds like the initial fight class just wasn't made that well tbh.

Tested the 5.4 frost dk profiel by King Similie - it seems to be using Frost Strike when KM is up and Obliterate is on CD.

Is that the issue you wanted resolving? If so just try grabbing that.

Most of the thinking is condition based.

What you basically want to fix your issue is another version of your Frost Strike that has a buff condition checking for KM. That is assuming you already have a Frost Strike that's used to dump RP at certain amounts?

If you're using your own then upload yours to here in a reply and I'll fix it.

Actually link the profile you're using, I'll go from there.

My sub profile is pretty mental I've got a lot of fake pooling and thinking going on.

For example I have eviscerate using 2 lua scripts that check if there's at least 10 seconds left on slice and 10 on rupture (it's more like 12 and 8 seconds but just generalising) and if there is it will use 5 CP on an evis if not then it will build into anticipation (fake combo points, basically 5 anticipation is like having 10 CP).

My slice and rupture abilities both refresh before they drop.

I'm not 100% but I think I can sort that issue for you using some of the lua scripts I currently have in my profile, I'll play around with a frost profile tomorrow.

But all that aside, sometimes its slow and it's not because of conditions - it just simply varies in speed on and off. The only issue I really have with it now sadly.

I already have 2 spells like that, I need it in one if possible hence lua script.

My spells are fine but sometimes it ignores conditions and does whatever it pleases. I think it's the speed/effectiveness of the bot tbh.

I've actually got a thread up about this on the beta test forum, the rotation doesn't use abilities as soon as they are ready, it feels slow and sluggish quite often - which is a shame.

Today I have something new, none rogue related.

Until I get help regarding a couple of my rogue threads I decided to leave that rather than do further damage trying to improve it.

I've now decided to make a protection warrior one to (the aim) a high level.

Very simple problem I have, the proc, buff 'Ultimatum' doesn't seem to work at all when placed alongside Heroic Strike or Cleave.

The buff gives you a rage free Heroic Strike or Cleave but doesn't work whether with a normal HS / Cleave or one using an lua script for either condition.

I noticed someone who created one of the other protection warrior profiles also said he had the same issue.

/bump

 /bump

I mean, am I supposed to refer to Hemorrhage as 'Sinister Strike' when trying to identify a debuff (bleed) on my target. There are several issues at hand, things I am uncertain of but even then - I have tried almost every possible combination of things to fix these issues but they still persist, even with the new 'Is Behind'

If it helps I also have a duplicate copy of backstab directly below it in the spell rotation order.

The only difference in this is that the 'lua script' to check if anticipatino stacks are < 5 is replaced by a combo points condition, also checking for < 5.

Alright, I'm going to need help. I've been testing the new 'Is Behind' and thought it was brilliant only to find there's been some occasions where it's been worse, it is also random - it hasn't happened on the same targets so I decided to question my rotation again.

I have 2 CP building abilities.

They are Backstab and Hemorrhage (Sinister Strike to Wrobot).

Backstab is from behind.

Hemorrhage is from in front.

Backstab conditions: -

Buff > Name Shadow Dance > Need: False

Buff > Name Stealth > Need: False

Buff > Name Vanish > Need: False

Is Spell Usable > Shadow Dance > Need: False

Target Buff Casted By Me > Hemorrhage > Need: True

Is Behind > Value: True

and an lua script condition that reads: -

"local nameSpell = GetSpellInfo(114015);

Wayne - Sub With Vanish ANTICIPATION 4.8.2.xml

Testing

With the new 'Is Behind' condition which seems fantastic btw, what would be the lua code taht would do the following: -

IF Is Behind = true then return true (so it backstab)

else Sinister Strike (this is actually Hemo for reference)

This would enable me to remove an entire spell and somewhat simplify things at my end. And perhaps help make the rotation perform faster.

Any ideas?