I see you removed the count value, that is fine as it wasn't used in this version (it was there for debugging). You also increased the waits. I am assuming it wasn't working as the code was running to fast, either the server or your connection was slower. I wan't able to test that and set the values for my setup, where the server is on my own local network and no-one else is on it so it is probably unreasonably fast. I could add a 'latency' value at the top of the file, and then use that to multiply all the waits, so for your case that would be set to 10 as you seem to have increased them all 10 fold.
I have refactored it a little, to suit my preferred 'functional' style. Not sure if it is everyone's cup of tea so I'll leave the original, but I do enjoy being able to chain functions with simple boolean return values, and it makes it very easy to compose and modify things like dps rotations that can form very complex decision trees.
I am curious what other devs think, it is full of side-effects and empty statements, which are normally considered smells as they can make the code hard to understand and work with, but since the purpose of the refactoring is to make it easier to understand and work with I don't think they are necessarily valid objections here.
Finally, I am sorry the capitalisation is all over the place, coming from a Java / Python / Prolog background the .net capitalisation always confuses me..
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Configuration;
using System.IO;
using System.Linq;
using System.Reflection;
using System.Threading;
using robotManager.Helpful;
using robotManager.FiniteStateMachine;
using robotManager.Products;
using wManager.Plugin;
using wManager.Wow.Helpers;
using wManager.Wow.Bot.States;
using wManager.Wow.Enums;
using wManager.Wow.ObjectManager;
using wManager.Wow.Class;
public class Main : wManager.Plugin.IPlugin
{
public void Initialize()
{
Logging.Write("JCToken: Started.");
int count = 0;
while (TurnIn() || Repair() || GetQuest()){}
Logging.Write("JCToken: Finished");
}
private bool TurnIn()
{
return HaveRepairedItem() && CompleteQuest();
}
private bool Repair()
{
return HaveQuest() && RepairItem();
}
private bool GetQuest()
{
return HaveItems() && AcceptQuest();
}
private bool HaveRepairedItem()
{
return HaveItemId(43298);
}
private void CompleteQuest()
{
wManager.Wow.Bot.Tasks.GoToTask.ToPositionAndIntecractWithNpc(ObjectManager.Me.Position, 28701);
System.Threading.Thread.Sleep(128);
Quest.SelectGossipActiveQuest(1);
System.Threading.Thread.Sleep(128);
Quest.CompleteQuest();
System.Threading.Thread.Sleep(256);
return true;
}
private bool HaveQuest()
{
return HaveItemId(43299);
}
private bool RepairItem()
{
foreach (WoWItem item in Bag.GetBagItem())
{
ItemInfo info = item.GetItemInfo;
int itemId = GetId(info.ItemLink);
if (itemId == 43299)
{
List<int> bagAndSlot = Bag.GetItemContainerBagIdAndSlot(info.ItemName);
Lua.LuaDoString("UseContainerItem(" + bagAndSlot[0] + "," + bagAndSlot[1] + ")");
System.Threading.Thread.Sleep(12500);
return true;
}
}
return false;
}
private bool HaveItems()
{
return HaveItemId(43297) && HaveItemId(36923);
}
private bool AcceptQuest()
{
foreach (WoWItem item in Bag.GetBagItem())
{
ItemInfo info = item.GetItemInfo;
int itemId = GetId(info.ItemLink);
if (itemId == 43297)
{
List<int> bagAndSlot = Bag.GetItemContainerBagIdAndSlot(info.ItemName);
Lua.LuaDoString("UseContainerItem(" + bagAndSlot[0] + "," + bagAndSlot[1] + ")");
Lua.LuaDoString("AcceptQuest()");
return true;
}
}
return false;
}
private bool HaveItemId(int Id)
{
foreach (WoWItem item in Bag.GetBagItem())
{
ItemInfo info = item.GetItemInfo;
int itemId = GetId(info.ItemLink);
if (itemId == Id)
{
return true;
}
}
return false;
}
private int GetId(String itemLink)
{
String pattern = "Hitem:";
int index = itemLink.IndexOf(pattern);
return Int32.Parse(itemLink.Substring(index + 6).Split(':')[0]);
}
public void Settings(){}
public void Dispose()
{
Logging.Write("JCToken: Stopped.");
}
}
Hello,
Right-click on WRobot.exe and then click Properties. On the Compatibility tab, select Disable Display Scaling On High DPI Settings, and then click OK:
https://www.youtube.com/watch?v=0xS-UCuyq7s
