PIR Enhancment shaman V 0.4 1.0.0

I'm not playing on retail atm. but how should some spells work if they look like this in your FightClass?

    <FightClassSpell>
      <FightClassConditions>
        <FightClassCondition>
          <ContionType>HealthPercent</ContionType>
          <Param xsi:type="FightClassConditionNumber">
            <Type>Smaller</Type>
            <Value>85</Value>
          </Param>
        </FightClassCondition>
        <FightClassCondition>
          <ContionType>Buff</ContionType>
          <Param xsi:type="FightClassConditionStringBool">
            <Name>Healing surge</Name>
            <Need>true</Need>
          </Param>
        </FightClassCondition>
      </FightClassConditions>
      <SpellName>Healing Surge</SpellName>
      <Priority>19</Priority>
    </FightClassSpell>

That means, the bot only casts "Healing Surge", if the buff "Healing Surge" exist on your character, but "Healing Surge" isn't a buff..

Here how it should look like:

    <FightClassSpell>
      <FightClassConditions>
        <FightClassCondition>
          <ContionType>HealthPercent</ContionType>
          <Param xsi:type="FightClassConditionNumber">
            <Type>SmallerOrEqual</Type>
            <Value>85</Value>
          </Param>
        </FightClassCondition>
        <FightClassCondition>
          <ContionType>ManaPercent</ContionType>
          <Param xsi:type="FightClassConditionNumber">
            <Type>BiggerOrEqual</Type>
            <Value>20</Value>
          </Param>
        </FightClassCondition>
      </FightClassConditions>
      <SpellName>Healing Surge</SpellName>
      <Priority>19</Priority>
      <CombatOnly>false</CombatOnly>
      <LockFrame>false</LockFrame>
    </FightClassSpell>

You could also add a timer, change the priority and add some more conditions to it.

im not sure haha, ill have a look later on, but it works lol, so if hp goes smaller than 85 the bot will heal, dont know what ive done but its worked for me.

like i said ill change it later to what u have said and see what happens, thanks for the feed back, this is my first ever fight class so im still learning :)

1 hour ago, PIR said:

im not sure haha, ill have a look later on, but it works lol, so if hp goes smaller than 85 the bot will heal, dont know what ive done but its worked for me.

 

like i said ill change it later to what u have said and see what happens, thanks for the feed back, this is my first ever fight class so im still learning :)

It works, cuz you have "Healing Surge" a second time in your FightClass, where the needed buff condition isn't added.

Just the first "Healing Surge" won't work, which is at the current highest priority 19.