Hey devs,

I've been working on some custom FightClass profiles and ran into something that's been driving me crazy for the past few hours. Not sure if this is intentional or an actual bug.

The problem:

The API uses "ContionType" instead of "ConditionType" - notice the missing 'i'. Same thing with the enum "FightClassContionsType".

I was writing XML files and naturally typed this (DOESN'T WORK):

<FightClassCondition>
    <ConditionType>HealthPercent</ConditionType>
    <Param xsi:type="FightClassConditionNumber">
        <Type>Smaller</Type>
        <Value>50</Value>
    </Param>
</FightClassCondition>

Spent forever debugging why my conditions weren't working. Finally checked the actual API docs and saw it's spelled ContionType. Changed to this and it works:

<FightClassCondition>
    <ContionType>HealthPercent</ContionType>
    <Param xsi:type="FightClassConditionNumber">
        <Type>Smaller</Type>
        <Value>50</Value>
    </Param>
</FightClassCondition>

My question is: Is this a typo that made it into production, or was there a reason for spelling it this way?

It's in both the CHM file and the HTML docs, so it's definitely in the compiled DLL. Here's what the API shows:

public class FightClassCondition
{
    public FightClassContionsType ContionType { get; set; }
    public FightClassConditionBase Param { get; set; }
}

If it's a bug: Any chance of fixing this in a future version? I know it would break existing profiles, but maybe you could support both spellings during a transition period?

If it's intentional: Could you add a note somewhere in the docs? Would've saved me a lot of time.

Just want to make sure I'm not missing something obvious here. Thanks!
 

Hello,

Yes, it's a typo that made it into production a long time ago. Unfortunately, fixing it now would break all existing FightClass profiles (XML serialization relies on the exact property name), so it has to stay as is.

Sorry for the lost time debugging, I understand the frustration. I'll add a note about it in the documentation.