EventsLuaWithArgs.OnEventsLuaWithArgs not firing some events

Hello, run this lua code and check if you have "SPELLCAST_STOP" in wow chat:

local frame = CreateFrame('Frame')
frame:RegisterAllEvents()
frame:SetScript('OnEvent',
    function()
       DEFAULT_CHAT_FRAME:AddMessage(tostring(event))
    end
)

This seem to be in wow bug: http://forum.nostalrius.org/viewtopic.php?t=12765&f=38

For the following code:

class AntiDrown
{
    private static DateTime BreathExpires = DateTime.MaxValue;

    public static void Start()
    {
        EventsLuaWithArgs.OnEventsLuaWithArgs += AntiDrownEventHandler;
    }

    public static void Stop()
    {
        EventsLuaWithArgs.OnEventsLuaWithArgs -= AntiDrownEventHandler;
    }

    private static void AntiDrownEventHandler(LuaEventsId id, List<string> args)
    {
        
        if (id == LuaEventsId.MIRROR_TIMER_START)
        {
            Logging.WriteDebug(args[0] + "  " + args[1]);
        }
        if (id == LuaEventsId.MIRROR_TIMER_START && args[0] == "BREATH")
        {
            //sets BreathExpires to be in the future by x milliseconds
            BreathExpires = DateTime.Now.AddMilliseconds(double.Parse(args[1]));
            Logging.WriteDebug("Breath has " + double.Parse(args[1]) + " milliseconds left");
        }
    }

    public static void DontDrown()
    {
        //check if we drown in less than 5 seconds
        while (Conditions.InGameAndConnectedAndAliveAndProductStartedNotInPause && DateTime.Now.AddSeconds(5) > BreathExpires)
        {
            Move.JumpOrAscend();
            Thread.Sleep(500);
        }
    }
}

I call Start and Stop methos from plugin.

Maybe the problem is that I reference TBC libraries of wRobot? I compile 1 dll for vanilla + tbc. 
It shouldn't really change anything, but maybe it does? I thought events remained the same
Maybe same problem as here:

I use TBC LuaEventsId.PLAYER_DEAD and it's different in different expacs.

Edited November 25, 20178 yr by Matenia

54 minutes ago, Matenia said:

Maybe the problem is that I reference TBC libraries of wRobot? I compile 1 dll for vanilla + tbc. 
It shouldn't really change anything, but maybe it does? I thought events remained the same
Maybe same problem as here:

I use TBC LuaEventsId.PLAYER_DEAD and it's different in different expacs.

It is that I think, Event id change frequently, and when you compile DLL, compiler put id in dll (not the enum name).

To fix it, try to (by sample) replace:

if (id == LuaEventsId.MIRROR_TIMER_START)

by

if (id.ToString() == "MIRROR_TIMER_START")

working solution