Avvi

Can you post your code here so that others can see? (myself included :))

1 hour ago, scripterx said:

Alright I'm very close to the solution (even if I realize it's kinda useless)..I'm glad that I can made it work, and yes thanks to your support and suggestions obviously. Basically there is a command "hooksecurefunc" which pretty much does the job. I redirect the CastSpellByName and also CastSpellByID (just in case) with a function and it's ok, the weird part is:

I tested with a Priest just the istant spells, it blocks for example the Shadowform, Dispersion, almost everything. But doesn't block Holy Nova, Prayer of Mending. So I said, maybe it doesnt block Holy spells, but guess what, Power Word: Shield is blocked..I mean what's the difference between PW:S and Holy Nova? I don't get it. if the command stop almost every istant spell why does it let me cast Holy nova and not PW:S?

Talking about spell with cast time, it doesn't block them at all. I don't know why?

Not a big deal, but the thing that blocks only some spell and other not its really really weird I can't understand

Technically Holy Nova is a Holy spell and PW:S is a discipline spell :) SO THERE'S A DIFFERENCE!!!

1 minute ago, wheels1911 said:

so i dont have to install 2 wow.exe? just use same battle.net preinstalled for both?

Some would recommend having two different installations , some would say even running on two different computers. It really just depends on how paranoid/how secure/how much you think blizzard looks into banning accounts. There's really no way to know how much is 'safe enough'.

Just now, wheels1911 said:

okay how do i create another login i tried already and when it starts to open battle.net it automatically detects my other one ??

Log out of your account on that browser. Or open a new browser and do it that way.

To be honest, I think it's safest to not bot on same login. Maybe I'm just paranoid, though. 

Just now, wheels1911 said:

so make the guild on my main account? and have the bot accounts be members of the guild and then just throw the stuff they make in there? is pretty much it

Guild can be made by any of them, as long as your main account has access to the gbank you should be good.

24 minutes ago, wheels1911 said:

so im obviously going to make each account have its own email and battle.net and wow in its own folder somewhere away from my main account on my computer

SO MY QUESTION is,

is it safe to just mailbox all my stuff from the bot account to my main does blizz track that.

How do i get my botted items over to my main account?

The best thing to do is to have a shared guild bank. Maybe an alt or something. Throw some invites out to people as a 'leveling' guild or something and keep a few tabs and the guild money as yours.

bump

I need a tester for this. If anyone is interested please message me.

I'm just going to vent, because posts like this irritate me.

Things that accomplish nothing when creating a thread like this. 

1. We have no way to troubleshoot this issue because no logs were provided
2. Nobody else is reporting issues, so the issue is obviously on YOUR side of things.
3. You call it 'Stupid BOT', but at the same time you even admitted that it has been working for 6+ months. How can you demand your money back AND at the same time in the same statement admit that it's been working perfectly fine up until recently. 

I suggest that if you WANT help and or WANT to provide constructive criticism, that you do so in a way that is helpful for everyone involved. Posts like this just make you seem like a jerk, and pretty much makes everyone else reading this not want to help you.

Here are the things you can try (and something EVERYONE should try) before submitting a post like this. And because you didn't report that you did, I will link to the page for you to run through some troubleshooting steps. Once you have done that, please provide some logs.

And some additional questions. 

1. Are you running Skype?
2. Do you use Teamviewer?
3. Do you have an NVIDIA graphics card that has some sort of overlay on?

Disable/Turn off the above and restart the bot.

If all else fails PLEASE provide the logs so that we , as a community, can troubleshoot your issues. How to collect logs, can be found below: 

Thanks

@Matenia I agree that what you're saying is valid, but I see that more as a workaround. There should be some sort of global setting that allows this to be configured. Perhaps the Quest profile should take precedence, but I'd like to see this implemented by @Droidz 

1 hour ago, dvdood said:

I am already using your fight class, modified for my needs :) I tried right now without modifications but same thing happens, vampiric touch sometimes is cast twice in a row for no reason :/

Oh, sorry for the issue with it then :( . I think the best way to fix this is to actually do it in c# or use lua. Like @forerun said, the bot starts casting again because it has not detected that the target has the buff yet. Alternatively, there may be a wait to add a wait time of preventing it from being casting successfully more than once every x seconds in the Not spell is C# code part of the Spell Settings. I do not have a code example of this, though. Or even.. ..  add a Thread.Sleep(250) right after the spell is casted. 

I think i was able to work around this in my fight class. take a look at mine here. Feel free to change yours to replicate my settings

1 hour ago, liquidsnake1989 said:

@avvi: Where would I put that C# code? As far as I'm concerned, the actual profiles are XML right?

This could be some sort of plugin, or could be inserted into XML. I'm at work right now, so i can't provide an example immediately. Try searching the forum (or i will create an example sometime later today).

This is still a WiP. I am working out a few kinks.

If you're interested, you can also take a look at my Plugin as well. It will alert you (send emails/play noise) etc, on death/whispers received/say message/character logged out. If you are able to react, you can potentially avoid getting banned. I will be adding features to alert on 'stuck' and or  when players are around you. 

3 minutes ago, Matenia said:

It's easy enough. All spells the client casts through the interface inevidbly go through CastSpellByName() (in Lua).
Therefore, you can overwrite CastSpellByName with your own function, do a condition for HoJ and just make it do nothing if target has CoS etc.

Do I think that guy is actually doing it that way? Probably not. He's likely just boasting/lying about something he has done in a way more simplistic way.

That's exactly my thoughts. doing the override just makes more sense here.

20 minutes ago, scripterx said:

Oh i see, I was thinking in a lua way ;)

Well idk how to explain.. basically the "UNIT_SPELLCAST_SENT" is the request you send to the server to launch a spell, and assuming conditions are true (target is in line of sight, in range...) then it triggers immediately SPELL_CAST_START (means the server accepted your request and the spell is going to land). So when this happens, the istant spell lands succesfully in a matter of milliseconds, while the spell with a cast time instead, begins to cast, and that's why I can stop this and not the other one.

So I want to have the request denied from the server, blocking me from doing that spell. Like having a message "is out of range" "not in the line of sight", something like this.

It's just curiosity, since that guy wrote that thing about the hammer of justice I was curious how it could even work.

 

It may be possible. I may even be wrong about something i said above. Hopefully someone else can chime in on this.

12 minutes ago, scripterx said:

I think you meant if cast time < or = 0 then stop casting (you said: cast).

In my C# example, it would be Cast.. because the event triggers based upon the spell beginning to cast. So, once the bot sees that it's a spell that has a cast time, it will stop the cast.

If your goal is to stop casting based on some sort of 'event'/'trigger', then I agree that checking to see if it's an instant cast/not one is irrelevant. I re-read your message, and I see that i completely glossed over your actual question. My mistake. 

Quote

And more than likely,  "can I stop an istant spell fired with UNIT_SPELLCAST_SENT? Or when that event starts, it's too late to block it?"

I think it is too late to block the spell.  I think the best thing to do is to check your condition before casting anything.

6 hours ago, scripterx said:

I forgot to mention I was writing that entirely on LUA and using pqr, so I can't put C code in it (at least i think). Also I'm not skilled enough on C language so I can't understand that code 100%.

The reason of my question is because I came across a guy who claimed he has some pqr scripts that do certain things which seemed weird to me, and I wanted to try by myself if that could been done for real, I never thought about that:

" [Hammer of Justice]: Will not be used if [Cloak of Shadows]/[Ice Block]/[Bladestorm]/[Spell Reflection] or any other spell that prevents you from landing it is up.
This script will stop you from casting [Hammer of Justice] if any of the spells stated above are up."

This is what he wrote. I mean I can understand a SpellStopCasting() when there is Spell Reflection up and you are casting so you avoid being reflected, it's not hard its like 2 rows of code... but how can a script prevent you from casting an istant spell, like Hammer of Justice?

So there are two ways:
1) The script has an automatic Hammer of Justice cast (which is completely idiot imho, what's the point?), and before casting it, it checks target's buffs.
2) The script blocks you from manually casting Hammer of Justice by mistake, like target with Cloak of Shadows.

If its the first option well it's the worst script ever for sure and I don't see how can people find that useful, if it's the second, that would be actually a good script for pvp (even if it's not hard to check target buffs before using a certain spell on it..) but it's still interesting code talking.

check the casttime of all spells before they are casted. If the cast time is greater than 0, then stop casting. If it's 0, then cast.

And I'm the opposite :D. I can read LUA, but it's definitely not my forte.

edited code above. Posting again so that you get a notification.

Modify your event listener to check to see if the spell that is being casted has a cast time  less than or equal  0. I have no idea what SpellStopCasting() does, but the below should work.

    private void watchForCast()
    {

        EventsLuaWithArgs.OnEventsLuaWithArgs += (LuaEventsId id, List<string> args) =>
        {

            if (id == wManager.Wow.Enums.LuaEventsId.UNIT_SPELLCAST_SENT)
            {
                if (instantCast(new Spell(args[1])) == false)
                {
                    SpellStopCasting();
                }
            }

        };

    }

    private bool instantCast(Spell spell)
    {

        return (spell.CastTime <= 0);

    }

This isn't t he most elegant thing, but you get the idea:

        var ElitesNearMe = ObjectManager.GetWoWUnitHostile().FindAll(p => p.GetDistance <= 10 && p.IsElite);

        if (ElitesNearMe.Count > 0)
        {
            // blacklist node
        }

5 minutes ago, kpeno said:

Have no idea bag this or no, but if bot in city with high amount people around  - bot start usage many CPu (plugins disabled, load default quest profile with only waittime) and stop bot after start, but wrobot.exe anyway eat 5% Cpu. For example: in fight or move to any area - bot usage around 2% CPu :)

To be honest, 3% increase does not seem like that much percentage. Also , depending on your system specs 3% may actually only be 1% on a different system.