Bot is drinking twice or more C#

[BetterSister 367]

Currently when i use this to drink it will usually drink twice or more (i don't know how cuz i can't do that manually) and then doesn't wait till mana is full

            if (ObjectManager.Me.ManaPercentage > 40 || ObjectManager.Me.InCombat || ObjectManager.Me.HaveBuff("Drink"))
            {
                Logging.WriteDebug("drinking false");
                return false;
            }
            Logging.WriteDebug("drinking now");
            ItemsManager.UseItem(RestoDruidSettings.CurrentSetting.Drinking);

            while (ObjectManager.Me.HaveBuff("Drink") && ObjectManager.Me.ManaPercentage < 100)
            {
                Logging.WriteDebug("we're sleeping");
                Thread.Sleep(1000);
            }
            return false;
        }

[D] 11:35:45 - drinking false
[D] 11:35:45 - drinking false
[D] 11:35:45 - drinking false
[D] 11:35:45 - drinking false
[D] 11:35:45 - drinking false
[D] 11:35:46 - drinking false
[D] 11:35:46 - drinking false
[D] 11:35:46 - drinking false
[D] 11:35:46 - drinking false
[D] 11:35:46 - drinking false
[D] 11:35:46 - drinking false
[D] 11:35:46 - drinking false
[F] 11:35:47 - [Spell] Cast Regrowth (Regrowth)
[D] 11:35:49 - drinking false
11:35:49 - [Looting] Loot Earthborer
[N] 11:35:49 - [Path-Finding] Path Count: 2
[F] 11:35:49 - [Spell] Cast Rejuvenation (Rejuvenation)
[D] 11:35:50 - drinking now
[D] 11:35:50 - drinking now
[D] 11:35:50 - drinking now
[D] 11:35:50 - drinking now
[D] 11:35:50 - drinking now
[D] 11:35:50 - drinking now
[D] 11:35:50 - drinking now
[D] 11:35:50 - drinking now
[D] 11:35:50 - drinking now
[D] 11:35:51 - drinking now
[D] 11:35:51 - drinking now
[D] 11:35:51 - drinking now
[D] 11:35:51 - drinking now
[D] 11:35:51 - drinking now
[D] 11:35:52 - drinking now
[D] 11:35:52 - drinking now
[D] 11:35:52 - drinking now
[D] 11:35:52 - drinking now
[D] 11:35:52 - drinking now
[D] 11:36:13 - drinking false
[D] 11:36:13 - drinking false
[D] 11:36:13 - drinking false
[D] 11:36:13 - drinking false
[D] 11:36:13 - drinking false

Apparently it ignores the "Drink" buff entirely and uses the item many times. Why?

[BetterSister 367]

Could someone give some help at this? The built in drink system in bot doesn't work for some reason with the fightclass :/

[Droidz 2737]

Hello,

After UseItem try to add wait time:

Thread.Sleep(Usefuls.Latency + 700);

 

[Droidz 2737]

Wait next update, I have improved default regen feature.

[BetterSister 367]

i don't know what part of it you improved but Regen module never ends now :D

[Droidz 2737]

15 hours ago, betterSister said:

i don't know what part of it you improved but Regen module never ends now :D

Not ends when mana is at 100%?

[BetterSister 367]

yes it doesn't end after mana reaches 100%

[Brian 10]

22 hours ago, betterSister said:

i don't know what part of it you improved but Regen module never ends now :D

Debug buffs through wrobot to see if the problem is with "Drink"

[BetterSister 367]

35 minutes ago, Chas3down said:

Debug buffs through wrobot to see if the problem is with "Drink"

it probably doesn't detect "Drink" buff properly because with this code it never detected the buff "Drink"

                if (ObjectManager.Me.HaveBuff("Drink"))
                {
                    Logging.WriteDebug("We have Drink buff");
                }

[Brian 10]

3 minutes ago, betterSister said:

it probably doesn't detect "Drink" buff properly because with this code it never detected the buff "Drink"

                if (ObjectManager.Me.GetBuff("Drink"))
                {
                    Logging.WriteDebug("We have Drink buff");
                }

Debug all your buffs to the logger to see if it's just called something else in wrobot(though I don't see why it would) or you can use buff ID (if that's implemented in wrobot)

[BetterSister 367]

26 minutes ago, Chas3down said:

Debug all your buffs to the logger to see if it's just called something else in wrobot(though I don't see why it would) or you can use buff ID (if that's implemented in wrobot)

Wrong code.. fixed it :D but it still doesn't detect

[BetterSister 367]

Now Regen is eating 1 food every 2sec even if it's already eating

[Brian 10]

5 hours ago, betterSister said:

Now Regen is eating 1 food every 2sec even if it's already eating

I saw this issue today for the first time, It isn't an everytime occurrence for me, was just when a certain set of parameters were met, I just restarted bot and it worked fine.(I can't remember the parameters, I can test more if needed)

 

note this was not with a custom regen class like I am assuming he is using.

[Droidz 2737]

If I understand, WRobot never end to drink. And flood usage of food item? Do you use only WRobot regen feature? What is name of your food/drink?

[BetterSister 367]

It floods the item untill it reaches around 90% mana or hp and sometimes doesn't continue from there. Happent most of the time while using my 1-13 quester and mage food (muffins and what the drink item name is.. I'll check them when i get home) 

[Droidz 2737]

Ok, do you use upper and lower cases (it is case sensitive)? Food is used again before that previous is finish (buff "Food")?

[BetterSister 367]

Yes case sensitive and yes it uses after few seconds from using last one

[Brian 10]

Can you do 

 

ObjectManager.Me.HaveBuff(DrinkID); 

[BetterSister 367]

9 hours ago, Brian said:

Can you do 

 

ObjectManager.Me.HaveBuff(DrinkID); 

Last time i tried it didn't detect the buff. I will be home in 9 hours then i can try to debug it more

[Brian 10]

21 minutes ago, betterSister said:

Last time i tried it didn't detect the buff. I will be home in 9 hours then i can try to debug it more

Just make a quick script to display all buff IDs , find drink id and use it

could be differnt the wowhead one or something maybe? So find it manually

[BetterSister 367]

8 minutes ago, Brian said:

Just make a quick script to display all buff IDs , find drink id and use it

could be differnt the wowhead one or something maybe? So find it manually

If you're at computer could you write the script before i get home? 

[Brian 10]

12 minutes ago, betterSister said:

If you're at computer could you write the script before i get home? 

going to bed right now

[BetterSister 367]

47 minutes ago, Brian said:

going to bed right now

Np I'll look at it

[BetterSister 367]

i wrote a quick plugin to see if checking the buffs work. For me it does now detect them properly

using robotManager.Helpful;
using robotManager.Products;
using System;
using System.Threading;
using wManager.Plugin;
using wManager.Wow.Helpers;
using wManager.Wow.ObjectManager;
using Timer = robotManager.Helpful.Timer;

public class Main : IPlugin
{
    private bool _isLaunched;
    public void Dispose()
    {
        _isLaunched = false;
        Logging.Write("Drink and eat debuger by betterSister disabled");
    }

    public void Initialize()
    {
        _isLaunched = true;
        Logging.Write("Drink and eat debuger by betterSister enabled");
        var timer = new Timer(5 * 1000);
        while (_isLaunched && Products.IsStarted)
        {
            try
            {
                if (timer.IsReady && Conditions.InGameAndConnectedAndProductStartedNotInPause)
                {
                    if (ObjectManager.Me.HaveBuff("Food"))
                    {
                        Logging.WriteDebug("We have Food buff");
                    }
                    if (ObjectManager.Me.HaveBuff("Drink"))
                    {
                        Logging.WriteDebug("We have Drink buff");
                    }
                    if (!ObjectManager.Me.HaveBuff("Drink") && !ObjectManager.Me.HaveBuff("Food"))
                    {
                        Logging.WriteDebug("We don't have Drink or Food buffs");
                    }
                }
            }
            catch (Exception e)
            {
                Logging.WriteDebug("ERROR ON DRINK EAT DEBUGER: " + e);
            }
            Thread.Sleep(150);
        }
    }
    public void Settings()
    {
        Logging.WriteDebug("We don't have settings");
    }
}

 

[Firefox 0]

Got the same problem on wotlk. Any ideas how to fix it ?