Jump to content

Ordush

Elite user
  • Posts

    1178
  • Joined

  • Last visited

Everything posted by Ordush

  1. Have you tried 1.2.2 after the wrobot update?
  2. And as promised i will add this to the next update, i'm in the middle of moving, so there won't be any updates this week. But i promise i will get to it. However i would suggest looking at plugins, i recall finding a plugin that does it for you. :) Edit:
  3. There has just been an update to WRobot: With a fix to lua memory leak, and path finding memory crash. I am pretty sure the lua memory leak is what caused your games to crash. I have ran a bot from level 1- 20 straight without ANY problems at all. so PLEASE update wrobot, and try again. And PLEASE report back.. I would love not to get my Fight Class comments soiled because of a bug in WRobot.
  4. Rolled back to 1.2.1 since more than 1 person have had problems with 1.2.2
  5. You need to use wrotation. And turn off movement control. :)
  6. Eat and drink is a general problem with WRobot, BUT i can make this a part of my fightclass, although it's a bit unorthodox. The resurrect does require a bit more work, because wrobot does not target dead targets, however. I can manually make the code for it, it will just take some time. In tbc, there are no such thing as roles, unfortunately. So i can't tell it to specificly thorns the tank. However, i can make it put thorns on focus. So if you have tank as focus, you get the same result. I will update all these things, and some of the things mentioned earlier. I am in the middle of a moving project, so i haven't got time to do any coding till next week.
  7. I didn't start out making it for leveling, it was a level 70 fightclass when i started out, only later did i add leveling support, but it does make a lot of sense, i will add it to the next update. :)
  8. Sounds really weird, i can guarantee you that the problem does not lie within the fightclass, I have people who has used it for level 1-70 and people using it at level 70, without any of the problems you are describing. If want me to, i can check it out on teamviewer, just PM me. :)
  9. The thing is, the "really obvious stutter" is only happening to you. Something must be set up wrong somewhere. Perhaps you have "Improve combat rotation speed" on under Advanced Settings? What level are you? What language is your client?
  10. Perfect! Thank you!
  11. Sorry for the general settings ofc. :) It's because I've made it so it updates some in-game lua variables every time it saves/loads. (It's so i don't have to make an addon with savedVariables to save my lua variables between sessions.) For my fightclass
  12. sounds to me like you have set up your wrobot or your game wrong somehow? Make sure that under Interface options -> Combat you have marked Auto Attack/Auto Shot. The move back is made so if you are too close to use ranged attacks it will move away from the mobs to make sure you are in the more than 5 yards from mobs (this is required to shoot). This only happens if your pet has aggro on the mob, so if your char goes in melee range (this is what happens if you don't mark Auto Attack/Auto Shot) it will keep going back into melee range.
  13. I see that it is marked as not a bug. Is this something that will change? Or will this just remain impossible in TBC?
  14. Hey all! The save and load functiosn are called 3 times. First load is when you open settings, save is called when you close settings, load is called again when you start the bot (press play) Is there any way that i can call the save or load during the rotaiton?
  15. There it is again, the condescending.. Why do you keep doing that? I did not copy paste your code, i allready did change the typo in HunterMarkDisabled i also changed the typo in LUA HunterMark... This did not change anything at all. Still the same in-game and in the log.
  16. If i do /run print(HuntersMarkDisabled) it shows false now, instead of nil. So it seems that it worked. But it still doesn't save the settings. Edit: If i stop and start the bot, it also turns HuntersMarkDisabled into false even if it was true before i started the bot. So it just defaults to false for some reason. Just as it did before.
  17. wow is not giving any errors. It's still just writing: PUSHED TO LUA VALUE HuntersMarkDisabled= and WRobot writes the same as before: 18:28:49 - Wrobot push to LUA HunterMark=False return result=False isCorret=True 18:28:51 - Wrobot fetch from LUA HunterMark=False
  18. It still gives the same result. even with ToLower (I copy pasted your code)
  19. I see. No hoenestly, i did not notice the Uppercase False. I will try doing lower case. :)
  20. My lua code is not missing anything, it works just fine without this code. I allready know what the problem is: It's this line: HuntersMarkDisabled = " + HuntersMark + "; It doens't work like that, it will just make HuntersMarkDisabled nil, instead of HuntersMark value. if (HuntersMark) { Lua.LuaDoString("HuntersMarkDisabled = true"); } else { Lua.LuaDoString("HuntersMarkDisabled = false"); } This however, does work.
  21. 16:48:53 - Wrobot push to LUA HunterMark=False return result=False isCorret=True 16:48:58 - Wrobot fetch from LUA HunterMark=False
  22. I really do appreciate your help mate. But do you HAVE to be so condescending? I am not a programmer no, everything i know i have taught myself over the last 6 months. I can promise you that i am not bad with lua at all! And yes i do know what "bug hunting" is, or as it is really called debugging... I already have debugged my lua code. Nothing is wrong with my lua code at all. Everything works perfect from the lua perspective. The only place where i am having issues is using the c#. If i was pro programmer, i would not go to these forums to ask for help. Anyway when i load the bot it gives me: PUSHED TO LUA VALUE HuntersMarkDisabled= When i open fight class settings i get: PUSHED TO LUA VALUE HuntersMarkDisabled= When i close fight class settings i get: FETCH FROM LUA VALUE HuntersMarkDisabled= So it seems as if it does not read the value from neither settings nor in-game. Although i know that earlier it has been reading the settings. Since it did change the value in settings, but it just didn't save them. I allrdy earlier figured that you can't do HuntersMarkDisabled = " + HuntersMark + "; Since it makes HuntersMarkDisabled nil. That is why i did: if (HuntersMark) { Lua.LuaDoString("HuntersMarkDisabled = true"); } else { Lua.LuaDoString("HuntersMarkDisabled = false"); }
  23. @camelot10 I have tried this: Just as you told me to, but if i do it like this. It does not work. HuntersMark just defaults to false here for some reason. It is as if it doesn't save. My example i set HuntersMarkDisabled = true in-game. then i close the bot, and do /reloadui so that my lua is cleared, then i load the bot and run it. now HuntersMarkDisabled = false Even SteadyShot which should not in any way be influenced by the game keeps going to "false". :O [Serializable] public class HunterBeastmasterSettings : Settings { const string FILE_PREFIX = "CustomClass-HunterBeastmaster"; [Setting] [DefaultValue(true)] [Category("Combat Spells - Hunter Abilities")] [DisplayName("Hunter's Mark Disabled")] [Description("Is Hunter's Mark Disabled?")] public bool HuntersMark { get; set; } [Setting] [DefaultValue(true)] [Category("Combat Spells - Hunter Abilities")] [DisplayName("Steady Shot")] [Description("Use Steady Shot")] public bool SteadyShot { get; set; } HunterBeastmasterSettings() { ConfigWinForm(new System.Drawing.Point(400, 400), "HunterBeastmaster " + Translate.Get("Settings")); } public static HunterBeastmasterSettings CurrentSetting { get; set; } public static bool Load() { try { if (File.Exists(AdviserFilePathAndName(FILE_PREFIX, ObjectManager.Me.Name + "." + Usefuls.RealmName))) { CurrentSetting = Load<HunterBeastmasterSettings>(AdviserFilePathAndName(FILE_PREFIX, ObjectManager.Me.Name + "." + Usefuls.RealmName)); CurrentSetting.PushToLua(); // SETTINGS LOADED, MUST BE TRANSLATED TO LUA return true; } CurrentSetting = new HunterBeastmasterSettings(); } catch (Exception e) { Logging.WriteError(FILE_PREFIX + " load error: " + e); } return false; } public bool Save() { try { CurrentSetting.FetchFromLua(); // LOAD SETTINGS FROM LUA return Save(AdviserFilePathAndName(FILE_PREFIX, ObjectManager.Me.Name + "." + Usefuls.RealmName)); } catch (Exception e) { Logging.WriteError(FILE_PREFIX + " save error: " + e); return false; } } void FetchFromLua() { HuntersMark = Lua.LuaDoString<bool>("return HuntersMarkDisabled"); } void PushToLua() { if (HuntersMark) { Lua.LuaDoString("HuntersMarkDisabled = true"); } else { Lua.LuaDoString("HuntersMarkDisabled = false"); } } }
  24. Yeah, i thought that was the problem, but i tried swapping them around as you just said, but then nothing happens at all, it neither loads nor saves anything, it just stays "false" no matter what. :/ And you are right, i don't fully understand it, since C# is not my strongest. Happy that you are willing to help, i will try swap them around and see if i was mistaken. :)
  25. Hey all This is a followup post from a previous one, i decided to make a new one to clear up all the clutter. I have some code below that is ALMOST working. The problem is: My variables set in the settings of my FC defaults to false when not loaded from in-game lua. Therefor when i reload the game, instead of setting my settings to what they were before, they just default to false. Anyone with more C# experience than me, who can see what is wrong? These variables are set in my lua: HuntersMarkDisabled = true/false When the profile is loaded: LoadedInLua = true <-- This is so it doesn't overwrite it's own settings before the profile is loaded. [Serializable] public class HunterBeastmasterSettings : Settings { const string FILE_PREFIX = "CustomClass-HunterBeastmaster"; [Setting] [DefaultValue(true)] [Category("Combat Spells - Hunter Abilities")] [DisplayName("Hunter's Mark Disabled")] [Description("Is Hunter's Mark Disabled?")] public bool HuntersMark { get; set; } [Setting] [DefaultValue(true)] [Category("Combat Spells - Hunter Abilities")] [DisplayName("Steady Shot")] [Description("Use Steady Shot")] public bool SteadyShot { get; set; } HunterBeastmasterSettings() { ConfigWinForm(new System.Drawing.Point(400, 400), "HunterBeastmaster " + Translate.Get("Settings")); } public static HunterBeastmasterSettings CurrentSetting { get; set; } public static bool Load() { try { if (File.Exists(AdviserFilePathAndName(FILE_PREFIX, ObjectManager.Me.Name + "." + Usefuls.RealmName))) { CurrentSetting = Load<HunterBeastmasterSettings>(AdviserFilePathAndName(FILE_PREFIX, ObjectManager.Me.Name + "." + Usefuls.RealmName)); CurrentSetting.FetchFromLua(); // LOAD SETTINGS FROM LUA return true; } CurrentSetting = new HunterBeastmasterSettings(); } catch (Exception e) { Logging.WriteError(FILE_PREFIX + " load error: " + e); } return false; } public bool Save() { try { CurrentSetting.PushToLua(); // SETTINGS LOADED, MUST BE TRANSLATED TO LUA return Save(AdviserFilePathAndName(FILE_PREFIX, ObjectManager.Me.Name + "." + Usefuls.RealmName)); } catch (Exception e) { Logging.WriteError(FILE_PREFIX + " save error: " + e); return false; } } void FetchFromLua() { var LoadedInLua = Lua.LuaDoString<bool>("return LoadedInLua"); if (LoadedInLua) { HuntersMark = Lua.LuaDoString<bool>("return HuntersMarkDisabled"); } } void PushToLua() { if (HuntersMark) { Lua.LuaDoString("HuntersMarkDisabled = true"); } else { Lua.LuaDoString("HuntersMarkDisabled = false"); } } }
×
×
  • Create New...