Jump to content

MrBottie

Members
  • Posts

    48
  • Joined

  • Last visited

File Comments posted by MrBottie

  1. I tested some heroic and LFR healing with it on my resto... First thing I deleted was the efflorescence in the profile as I think it made some weird choices with it. I prefer to cast it manually.
    Another thing I noticed is that it casts barkskin while everyone is almost at full health... Maybe it's because of this:

    if (ObjectManager.Me.ManaPercentage <= RestoSettings.CurrentSetting.Barkskin)
                {
                    SpellManager.CastSpellByNameOn(_barkskin.Name, ObjectManager.Me.Name);
                    Logging.WriteFight(_barkskin.Name + " on " + ObjectManager.Me.Name);
                    return true;
                }

    Me.ManaPercentage ?? Think this should be a health check iso mana check, no?

    I'll keep on testing, thanks for this profile pasterke <3

  2. if (t.Any())
                    {
                        int count = 0;
                        int tel = 0;
                        if (getPartyMembers().Count() > 5)
                            tel = 5;
    
                        if (getPartyMembers().Count() < 6)
                            tel = 3;
    
                        if (tel >= count)
                        {
                            SpellManager.CastSpellByNameLUA(_essenceOfGhanir.Name);
                            Logging.WriteFight(_essenceOfGhanir.Name);
                            return true;
                        }
                    }

    @Pasterke don't you always get in the if (tel>=count) condition this way? It seems like tel will always be 3 or 5 and bigger than count which is set to 0?

    ...Or I'm missing something :-)

    Feral Druid Legion

       2545    46
    21 minutes ago, Pasterke said:

    I'm experimenting :)

    For what it's worth, can't you read the combat log each time you cast something and wait for a success/failed log of that specific cast?

    SPELL_CAST_SUCCESS / SPELL_CAST_FAILED ?

    What were you thinking of if I can ask?

     

    Feral Druid Legion

       2545    46
    33 minutes ago, Pasterke said:

    You see, the bot's routine is an while loop. That means he iterate over and over the routine. When a condition is true, he cast the spell, but the time he cast the spell, the routine already iterate 1 or more times the routine. If a condition is true, he keep this in memory. So, if finished casting the 1st spell, he casts the true in his memory etc ...

    On one given moment you may have 2 or more trues in memory and he will cast those first instead of casting the spell on the exact moment you want it.

    That's the whole problem with this bot to do decent dps or decent healing.

    Isn't this solvable with some sleep alike function (global cooldown) or wait for cast function when you return true? Maybe @Droidz can answer this easily?

  3. On ‎3‎/‎10‎/‎2016 at 2:19 PM, Bugreporter said:

    Vanish usage is difficult:

    1. PvP = no problem

    2. PvE =
    2.1 Only you and the target. Not usable, Fight will be resettet
    2.2 you fight against a target, but another one has the Aggro. No Problem
    2.3 same scenario, but other enemys fighting against you. Aggro get lost.
    2.4 in Group (no dungeon): Possible, but only if another group-member is near enough to get the aggro.
    2.5 in Group (dungeon): no problem in the most cases,except you want help an attacked healer

    point 2.2 - 2-5 is not really solveable/detectable via lua.

     

    Exsanguinate: I will have a look at this.
     

    Maybe you can deal with vanish based on this api return?
     
    inInstance, instanceType = IsInInstance()
     
    inInstance 
    Boolean - Whether the player is in an instance; nil otherwise.
    instanceType 
    String - The instance type:
    • "none" when outside an instance
    • "pvp" when in a battleground
    • "arena" when in an arena
    • "party" when in a 5-man instance
    • "raid" when in a raid instance
    • nil when in an unknown kind of instance, eg. in a scenario
  4. On 30-9-2016 at 1:00 PM, Bugreporter said:

    In the next few days i dont have access to my wow-account, to check it

    So: did you start in stealth?

    - If so, is "Break Stealth" active ?
    - if not, did the bot start after you start the first attack ?

    The hole script works conserative. It doesn't start an attack before you are in combat/being attacked. The reason is pick pocketing. The only attack that starts out of combat is "Break Stealth". This works god for the most usages, except Test Dummy

    If nothing helps, test it with elite mobs. They live long enough to get an good overview ;-)

    Still can't get the rotation started on test dummies :-(

    Another thing, When i'm doing world quests, I don't want to roll the bones on regular lvl110 mobs so I added the "Target Level" condition set on "Bigger than 110" but it still rolls the dices... any idea? 

×
×
  • Create New...