Jump to content

No fish are hooked


Recommended Posts

Hello as the title says the fishbot does not work..

 

It launches and use lure, but relaunch every 5-15 second with the message "No fish are hooked"... I have tried all min/max MS/latency and been trying the min/max MS that works with skinning, but to no help..... 

I have also tried disable all addons and disable lure and so on.. Nothing seems to make it work...

 

Playing on server "lightshope"

[F] 00:56:17 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:56:29 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:56:52 - [Spell] Cast Fishing (Fishing) fish
[F] 00:57:03 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:57:16 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:57:39 - [Spell] Cast Fishing (Fishing) fish
[F] 00:57:49 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:58:00 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:58:11 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:58:30 - [Spell] Cast Fishing (Fishing) fish 
[F] 00:58:46 - [Spell] Cast Fishing (Fishing)fish 
[F] 00:58:58 - [Spell] Cast Fishing (Fishing) no fish

Link to comment
Share on other sites

I set a delay of 700-900
switched off the combat class
and set the wait after loot 1200 ms

this solved the problem. but 1 out of 10 times is No fish are hooked..

 

The statistics of the bot were 327 loot. but there were only 259 fish in the bag

Link to comment
Share on other sites

  • 2 weeks later...

To find the cause go to fishable water, open developer tools and run this C# code:

Spell Fising = new Spell("Fishing");
for (int i=0; i<20; i++) {
	Fishing.Launch(false, false, true);
	Others.Wait(2000);
	Logging.Write("Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting");
	Others.Wait(100);
}

Write what you see in log. Is there GUID value every time?

Link to comment
Share on other sites

  1. I click Tools
  2. then I click Development Tools
  3. then I paste your code into the textbox
  4. then I click C# (ret value in wManager.DevelopmentTools.OutPutCSharp) button
  5. the textbox adds this:
// wManager.DevelopmentTools.OutPutCSharp= 
// Execute time: 375

 

  1. my log says this:
[F] 16:23:26 - [Spell] Cast Fishing (Fishing)
[E] 16:23:36 - Compilator Error :
c:\Users\<User>\AppData\Local\Temp\gax352rt.0.cs(24,10) : error CS0117: 'wManager.Wow.Helpers.Fishing' does not contain a definition for 'Launch'
[E] 16:23:36 - Cannot run code, look log.
[F] 16:23:37 - [Spell] Cast Fishing (Fishing)

 

Link to comment
Share on other sites

Thats because of a typo in his code as well as is spell being the same name as one of the helper methods.

As you can see he named the spell Fising not Fishing. The Launch method belongs to the spell. If you keep the same code and misspell it in the launch, it should work.

 

Link to comment
Share on other sites

Sorry, wrong variable name. Need to rename, for examlpe, Fishing -> _f

Spell _f = new Spell("Fishing");
for (int i=0; i<20; i++) {
	_f.Launch(false, false, true);
	Others.Wait(2000);
	Logging.Write("Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting");
	Others.Wait(100);
}

 

Link to comment
Share on other sites

Thanks for the advice. There is progress.

[F] 18:00:02 - [Spell] Cast Fishing (Fishing)

[E] 18:00:04 - Compilator Error :
c:\Users\User\AppData\Local\Temp\0dzrh0hh.0.cs(26,41) : error CS1061: 'wManager.Wow.Class.Spell' does not contain a definition for 'SearchBobber' and no extension method 'SearchBobber' accepting a first argument of type 'wManager.Wow.Class.Spell' could be found (are you missing a using directive or an assembly reference?)

[E] 18:00:04 - Cannot run code, look log.
[F] 18:00:14 - [Spell] Cast Fishing (Fishing)

I guess SearchBobber has to be named correctly then.

Link to comment
Share on other sites

Cheers headcrab. Thanks for the support.

The log says:

19:10:33 - Bobber GUID = 0
[F] 19:10:33 - [Spell] Cast Fishing (Fishing)
19:10:35 - Bobber GUID = 0
[F] 19:10:35 - [Spell] Cast Fishing (Fishing)
...

 Can you make something out of it?

Link to comment
Share on other sites

Not latency, but 3000 in my code 

Spell _f = new Spell("Fishing");
for (int i=0; i<10; i++) {
	_f.Launch(false, false, true);
	Others.Wait(3000);
	Logging.Write("Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting");
	Others.Wait(100);
}

Can you find minimum, maybe 2500 ?

Fishing task not depends on latency, you will have to patch wManager.dll, or wait until @Droidz do it. Thats why i say "bad"

Link to comment
Share on other sites

I tried your code with 2500 and this is what the log says:

[F] 19:59:27 - [Spell] Cast Fishing (Fishing)
19:59:29 - Bobber GUID = 743112712
[F] 19:59:29 - [Spell] Cast Fishing (Fishing)
[F] 19:59:29 - [Spell] Cast Fishing (Fishing)
19:59:31 - Bobber GUID = 743112712
[F] 19:59:32 - [Spell] Cast Fishing (Fishing)
[F] 19:59:32 - [Spell] Cast Fishing (Fishing)
19:59:34 - Bobber GUID = 743112712
[F] 19:59:34 - [Spell] Cast Fishing (Fishing)

The char casts ten times but loots too early.

Link to comment
Share on other sites

  • 2 weeks later...

You can patch wManager.dll this way:

1) Make shure bot cant find bobber. Go to fishing water and run this c# code in developement tools: 

Spell _f = new Spell("Fishing");
for (int i=0; i<10; i++) {
	_f.Launch(false, false, true);
	Others.Wait(2000);
	Logging.Write("Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting()");
	Others.Wait(100);
}

look in the log. If there always this strings, it means bot cant find bobber:

[F] 19:10:33 - [Spell] Cast Fishing (Fishing)
19:10:35 - Bobber GUID = 0

2) try to find minimum wait value to find bobber. Gradually increase 2000 -> 3000 until you see in log non-zero bobber GUID. This code will help you:

Spell _f = new Spell("Fishing");
for (int i=2000; i<3000; i=i+100) {
	_f.Launch(false, false, true);
	Others.Wait(i);
	Logging.Write("Wait:" + i+ "   Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting()");
	Others.Wait(100);
}

 If found, you can patch program

3) download and install dnSpy (dnSpy.zip)

4) run dnSpy, open wManager.dll and find method wManager.Wow.Bot.Tasks.FishingTask.LoopFish (with many arguments)

s3.PNG.6205cbd8be9bced26563169d9aff4a84.PNG

You will see obfuscated code, but there is string easy to find. It should looks like this (contains symbols ThreadStart):

s4.PNG.e42bd4cc9ce6c71091175314b5c2b24a.PNG

5) click on the method in the end of string (name can be different). You will open this method. Find in this method string "Others.Wait". This is place to patch

s5.PNG.88bd99f5a8aefb5c37a26d32a479c819.PNG

6) Right click ans select "Edit Method (C#)". As argument type value you found, for example, 2500:

s6.PNG.d19da711a629dff6a9dc8de7326fc620.PNG

7) Compile, save, and enjoy

Never update your robot, or do this steps again, if updated, and fising not works as before

Edited by headcrab
code to find minimum wait time
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...