No fish are hooked

[Sasha301 0]

Hello as the title says the fishbot does not work..

 

It launches and use lure, but relaunch every 5-15 second with the message "No fish are hooked"... I have tried all min/max MS/latency and been trying the min/max MS that works with skinning, but to no help..... 

I have also tried disable all addons and disable lure and so on.. Nothing seems to make it work...

 

Playing on server "lightshope"

[F] 00:56:17 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:56:29 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:56:52 - [Spell] Cast Fishing (Fishing) fish
[F] 00:57:03 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:57:16 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:57:39 - [Spell] Cast Fishing (Fishing) fish
[F] 00:57:49 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:58:00 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:58:11 - [Spell] Cast Fishing (Fishing) no fish
[F] 00:58:30 - [Spell] Cast Fishing (Fishing) fish 
[F] 00:58:46 - [Spell] Cast Fishing (Fishing)fish 
[F] 00:58:58 - [Spell] Cast Fishing (Fishing) no fish

[Droidz 2738]

Hello, Can you share your log file please ( https://wrobot.eu/forums/topic/1779-how-to-post-your-log-file-with-your-topic/ ).

[Sasha301 0]

23 дек 2017 23H51.log.html

[Droidz 2738]

Hello, you min latency is to low.

In min/max latency try to put 600/700.

try also to disable your fightclass

[Sasha301 0]

I set a delay of 700-900
switched off the combat class
and set the wait after loot 1200 ms

this solved the problem. but 1 out of 10 times is No fish are hooked..

 

The statistics of the bot were 327 loot. but there were only 259 fish in the bag

[Sasha301 0]

the problem continues. 4 out of 10 No fish are hooked

addons OFF/

Latency 600-700

fightclass disabled

[Sasha301 0]

Admin. help me pls. server Lightshope!

1 video settings.   https://www.youtube.com/watch?v=0qxPYuNhleM

2 video look for no fish are hooked// Im buy this bot for fishing. and this not work...          https://www.youtube.com/watch?v=FCHAEKeGX04

[otherguym 0]

I am experiencing the same problem. The bot loots the fish too early it seems. So no fish is hooked.

I tried:

• turning off addons
• setting min-max latency: 600-700
• disabling fight class

Problem persists.

17 Jan 2018 08H27.log.html

[headcrab 32]

To find the cause go to fishable water, open developer tools and run this C# code:

Spell Fising = new Spell("Fishing");
for (int i=0; i<20; i++) {
	Fishing.Launch(false, false, true);
	Others.Wait(2000);
	Logging.Write("Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting");
	Others.Wait(100);
}

Write what you see in log. Is there GUID value every time?

[otherguym 0]

1. I click Tools
2. then I click Development Tools
3. then I paste your code into the textbox
4. then I click C# (ret value in wManager.DevelopmentTools.OutPutCSharp) button
5. the textbox adds this:

// wManager.DevelopmentTools.OutPutCSharp= 
// Execute time: 375

 

1. my log says this:

[F] 16:23:26 - [Spell] Cast Fishing (Fishing)
[E] 16:23:36 - Compilator Error :
c:\Users\<User>\AppData\Local\Temp\gax352rt.0.cs(24,10) : error CS0117: 'wManager.Wow.Helpers.Fishing' does not contain a definition for 'Launch'
[E] 16:23:36 - Cannot run code, look log.
[F] 16:23:37 - [Spell] Cast Fishing (Fishing)

 

[Marsbar 228]

Thats because of a typo in his code as well as is spell being the same name as one of the helper methods.

As you can see he named the spell Fising not Fishing. The Launch method belongs to the spell. If you keep the same code and misspell it in the launch, it should work.

 

[headcrab 32]

Sorry, wrong variable name. Need to rename, for examlpe, Fishing -> _f

Spell _f = new Spell("Fishing");
for (int i=0; i<20; i++) {
	_f.Launch(false, false, true);
	Others.Wait(2000);
	Logging.Write("Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting");
	Others.Wait(100);
}

 

[otherguym 0]

Thanks for the advice. There is progress.

[F] 18:00:02 - [Spell] Cast Fishing (Fishing)

[E] 18:00:04 - Compilator Error :
c:\Users\User\AppData\Local\Temp\0dzrh0hh.0.cs(26,41) : error CS1061: 'wManager.Wow.Class.Spell' does not contain a definition for 'SearchBobber' and no extension method 'SearchBobber' accepting a first argument of type 'wManager.Wow.Class.Spell' could be found (are you missing a using directive or an assembly reference?)

[E] 18:00:04 - Cannot run code, look log.
[F] 18:00:14 - [Spell] Cast Fishing (Fishing)

I guess SearchBobber has to be named correctly then.

[headcrab 32]

Simly copy paste my code, or do not rename Fishing in string 

Logging.Write("Bobber GUID = "+Fishing.SearchBobber());

[otherguym 0]

Cheers headcrab. Thanks for the support.

The log says:

19:10:33 - Bobber GUID = 0
[F] 19:10:33 - [Spell] Cast Fishing (Fishing)
19:10:35 - Bobber GUID = 0
[F] 19:10:35 - [Spell] Cast Fishing (Fishing)
...

 Can you make something out of it?

[headcrab 32]

Its bad. Try to increase wait time 2000->3000, but not much more. Does it helps?

[otherguym 0]

The bobber has a GUID now. I increased the latency to your suggested  values.

The problem still persists.

[headcrab 32]

Not latency, but 3000 in my code 

Spell _f = new Spell("Fishing");
for (int i=0; i<10; i++) {
	_f.Launch(false, false, true);
	Others.Wait(3000);
	Logging.Write("Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting");
	Others.Wait(100);
}

Can you find minimum, maybe 2500 ?

Fishing task not depends on latency, you will have to patch wManager.dll, or wait until @Droidz do it. Thats why i say "bad"

[otherguym 0]

I tried your code with 2500 and this is what the log says:

[F] 19:59:27 - [Spell] Cast Fishing (Fishing)
19:59:29 - Bobber GUID = 743112712
[F] 19:59:29 - [Spell] Cast Fishing (Fishing)
[F] 19:59:29 - [Spell] Cast Fishing (Fishing)
19:59:31 - Bobber GUID = 743112712
[F] 19:59:32 - [Spell] Cast Fishing (Fishing)
[F] 19:59:32 - [Spell] Cast Fishing (Fishing)
19:59:34 - Bobber GUID = 743112712
[F] 19:59:34 - [Spell] Cast Fishing (Fishing)

The char casts ten times but loots too early.

[headcrab 32]

My code does not loots, just test for SearchBobber. If 2000 not works, it means fisherbot will not work for you, because there is 2000 delay hardcoded in bot. Write it to bugtracker, maybe @Droidz will fix it. Or patch FishingTask class

[xj3r3myx 2]

@Droidz

 

I am having this same issue

[headcrab 32]

You can patch wManager.dll this way:

1) Make shure bot cant find bobber. Go to fishing water and run this c# code in developement tools: 

Spell _f = new Spell("Fishing");
for (int i=0; i<10; i++) {
	_f.Launch(false, false, true);
	Others.Wait(2000);
	Logging.Write("Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting()");
	Others.Wait(100);
}

look in the log. If there always this strings, it means bot cant find bobber:

[F] 19:10:33 - [Spell] Cast Fishing (Fishing)
19:10:35 - Bobber GUID = 0

2) try to find minimum wait value to find bobber. Gradually increase 2000 -> 3000 until you see in log non-zero bobber GUID. This code will help you:

Spell _f = new Spell("Fishing");
for (int i=2000; i<3000; i=i+100) {
	_f.Launch(false, false, true);
	Others.Wait(i);
	Logging.Write("Wait:" + i+ "   Bobber GUID = "+Fishing.SearchBobber());
	Lua.LuaDoString("SpellStopCasting()");
	Others.Wait(100);
}

 If found, you can patch program

3) download and install dnSpy (dnSpy.zip)

4) run dnSpy, open wManager.dll and find method wManager.Wow.Bot.Tasks.FishingTask.LoopFish (with many arguments)

You will see obfuscated code, but there is string easy to find. It should looks like this (contains symbols ThreadStart):

5) click on the method in the end of string (name can be different). You will open this method. Find in this method string "Others.Wait". This is place to patch

6) Right click ans select "Edit Method (C#)". As argument type value you found, for example, 2500:

7) Compile, save, and enjoy

Never update your robot, or do this steps again, if updated, and fising not works as before

Edited January 26, 2018 by headcrab
code to find minimum wait time

[xj3r3myx 2]

I do get a bobber GUID from your original code - but my fishbot seem to click the fish very early before fish are hooked, or at random intervals. 

#Sasha301 did you find a soliution?

[twoez 0]

I can't get my fisher to work either. Same problem, it says no fish are hooked. 

[twoez 0]

I can't get my fisher to work either. Same problem, it says no fish are hooked.