Ordush
Elite user-
Posts
1171 -
Joined
-
Last visited
Content Type
Forums
Articles
Bug Tracker
Downloads
Store
Everything posted by Ordush
-
I can't seem to find which Methods you have changed, am i blind or can you list affected methods? :)
-
This does not fix anything? The first one just tells if a auto-shot is in range, the other one checks attack. It's nice that we can check if a spell is in range. However, this does not give the range. We need the number (Range as a number). The methods listed above will make a shit ton of noise if you play with sound, and it uses lua which will slow down the fightclass. Also try and look at what i wrote above.. I wrote EXACTLY that code. To me it's clear that what is not working is the mob size calculator.
-
[PAID] [PVE] [RAID] Restoration - Druid - TBC(2.4.3) by Ordush
Ordush commented on Ordush's file in Fight Classes - TBC
Partybot makes sense, because there movement is controlled by bot. But it should not be a problem for the druid. However, i will look into it. :) Note: I am currently very sick, and have been since november 2017. I'm getting better for every day, and as soon as i'm fully myself again, i will do a lot of updates to all my fightclasses.- 85 comments
-
- tbc
- fightclass
-
(and 5 more)
Tagged with:
-
[PAID] [PVE] [RAID] Restoration - Druid - TBC(2.4.3) by Ordush
Ordush commented on Ordush's file in Fight Classes - TBC
- 85 comments
-
- tbc
- fightclass
-
(and 5 more)
Tagged with:
-
[PAID] [PVE] [RAID] Beastmaster - Hunter - 1-70 - TBC(2.4.3) by Ordush
Ordush commented on Ordush's file in Fight Classes - TBC
- 91 comments
-
[PAID] [PVE] [RAID] Beastmaster - Hunter - 1-70 - TBC(2.4.3) by Ordush
Ordush commented on Ordush's file in Fight Classes - TBC
- 91 comments
-
You are seriously stating here that it doesn't seems to work? :O Ofc. it works. Please refer to the FAQ. If this does not solve your issues, please don't hesitate to visit my discord channel for more help. That error you see there is not actually an error, it's just WRobot that thinks there is a format exception.
- 166 comments
-
[PAID] [PVE] [RAID] Restoration - Druid - TBC(2.4.3) by Ordush
Ordush commented on Ordush's file in Fight Classes - TBC
- 85 comments
-
- tbc
- fightclass
-
(and 5 more)
Tagged with:
-
- 166 comments
-
@Droidz Sorry bout the late answer, i was hospitalized. This prints 11,3342 as range, when it's 8 yard range. So not better. =/
-
- 166 comments
-
Imagine your fightclass being a text with instruments, where each instrument can't be read without reading the other instruments coming before it first. So it reads form top to buttom, then it repeats. (Loop). The amount of instructions it has to read through determines how fast it reads the page. So if you have a shit ton of conditions, it'll slow down the reading process. Reading from memory goes faster than looking for in-game lua conditions. So if you want the 'reading speed' to increase, you want to decrease the amount of in-game lua conditions or make your overall conditions smarter. I will make an example here for you on how you can make your conditions smarter (faster). Say you have 4 spells after eachother. Spell1 (Cast this if if not in combat, cast this if mana is x%) Spell2 (Cast this if not in combat, cast this if mana is y%) Spell3 (Cast this if not in combat, cast this if mana is z%) Spell4 (Cast this if not in combat, cast this if mana is w%) You change this to be smarter like this: My4Spells (Cast this if not in combat) { Spell1 (Cast this if mana is x%) Spell2 (cast this if mana is y%) Spell3 (cast this if mana is z%) Spell4 (cast this if mana is w%) } this is a very very rough and stupid example, but it should get the point out. So in short, to speed up the condition reading. You want: 1. Memory > Lua conditions 2. Smart code 3. If you look at my Vanilla/TBC hunter fightclasses (or any fightclass i have made) you will see right away that i have used TONS of Lua. So it can be done, but you want to read through lua as few times as possible. :) 4. The higher FPS your fightclass has the faster it reads through the page (FRAMES). So increasing the FPS both for the fightclass AND in-game will add a little speed (just like Droidz said it). Hope this helps.
-
Still no word? @Droidz
-
@Droidz Pretty please look into this <3
-
It works fine in the way that i am using it. In my TBC profile, this works perfectly, no bugs etc. The issue here is the range being off, which is what i started saying. :) I think i've produced enough evidence. :) Also, the range needed for ranged attacks is set to 5 yards. in vanilla it's not 5 yards it's 8 yards. :)
-
wManager.Events.FightEvents.OnFightLoop += (unit, cancelable) => { var unitsAffectingMyCombat = ObjectManager.GetUnitAttackPlayer(); var unitsAttackMe = unitsAffectingMyCombat.Where(u => u != null && u.IsValid && u.IsTargetingMe).ToList(); LuaUtils.wrPrint("GetDistance:" +ObjectManager.Target.GetDistance); LuaUtils.wrPrint("DistanceGood:" + _AutoShot.IsDistanceGood); if (ObjectManager.Target.IsAttackable && unit.IsValid && !ObjectManager.Me.IsCast && ObjectManager.Target.GetDistance < 8 && !ObjectManager.Target.IsTargetingMe && !ObjectManager.Target.GetMove && unitsAttackMe.Count <= 0) { Move.Backward(Move.MoveAction.PressKey, 3000); } }; However, it's not so much the refresh rate of the distance calculation, because as you can see in my screenshot, i am standing completely still at 7yard range from the mob, and WRobot thinks i'm 9 yards away. Edit: When a mob is melee hitting me WRobot thinks it's 3 yards away.
-
Please @Droidz read this, and see my screenshot. The code to print ObjectManager.Target.GetDistance i use is here: public static void wrPrint(float message) { { Lua.LuaDoString("DEFAULT_CHAT_FRAME:AddMessage('" + message.ToString() + "')"); } } Then you can just put wrPrint(ObjectManager.Target.GetDistance); Into a while loop or into wManager.Events.FightEvents.OnFightLoop += (unit, cancelable) => { }; if you only wanna spam your chat when actually shooting a mob or dummy. I need to be 13.3 yards away from the target, for it to be in range with a 8 yard spell (any ranged hunter attack). So when i am actually 8 yards away from the target, ObjectManager.Target.GetDistance thinks i'm 13.3 yards away. This is both with and without Calculate interact/combat distance by target size in general advanced settings. wrPrint("DistanceGood:" + _AutoShot.IsDistanceGood); This prints false under what ObjectManager.Target.GetDistance claims is 5 yards, above 5 yards it prints true. But in vanilla Auto Shot distance is not 5 Yards, it's 8 Yards. If you want to compare you IsDistanceGood with in-game "Is Distance Good" checker then you can do /run DEFAULT_CHAT_FRAME:AddMessage(IsActionInRange(1)) then put whatever spell you wanna check against on action bar slot 1. Like Auto Shot
-
@Droidz It should be very easy to reproduce, because i am using the code you supplied in another thread. :)
-
I don't see that anywhere in my settings, but i tried turning off Calculate interact/combat distance by target size. Did not help anything. :( Edit: It looks like the target size calculator is what is not working.
-
I even tried telling it to walk away if !_AutoShoot.IsDistanceGood , same problem (_AutoShot is Spell "Auto Shot")
-
It seems that the 'range' calculator for Vanilla is off by a few yards. If i tell the bot to walk away from mobs if they are less than 8 yards range from me (to be able to use ranged abilities as hunter), the bot does not walk far enough away (it walks less then 8 yards away). If i set it to 12 yards instead of 8, then it will walk far enough away for the mob to be more then 8 yards range from me) This works totally fine in TBC, but not in Vanilla.
-
I will add aspect of the monkey, and a option to turn off backpeddal, changing the range to 8 does not work, there is a bug either with WRobot or wow classic (probably wrobot), that makes it so it can't use ranged abilities when it is set to 8 yards. I can try set it to 8 yards again, see if anything has changed with WRobot updates. In vanilla, you can't check for immunity, but i can set a timer on Serpent Sting, which however, is a bad idea, because serpent sting can miss. I will look into if i can read for "immune" somehow. These are the best 'fixes' i can come up with for now. :) I will however look more into it. :)
- 166 comments
-
[PAID] [PVE] [RAID] Beastmaster - Hunter - 1-70 - TBC(2.4.3) by Ordush
Ordush commented on Ordush's file in Fight Classes - TBC
- 91 comments