[PVP] Warrior Prot - charge not work

[Garub 6]

Hello everyone, I creating a Fight Class for my Warrior tank pvp (3.3.5- LK), and I'm facing a problem:

The charge does not work (I do not know what I'm doing wrong but it does not start the fight with the ability to charge.

Warrior_Prot_xxx.xml

13 mai 2018 14H34.log.html

[eeny 523]

Charge- condition me in combat = true

Remove this condition or set to false

[Garub 6]

9 minutes ago, eeny said:

Charge- condition me in combat = true

Remove this condition or set to false

I did the test and it only worked when the hostile mob saw me and came to fight. In an arena when you want to use the charge, will I have to go into combat first? There would be no way to start when I clicked the right mouse button.

[skeletonboy360 5]

Not xml, might be able to change some stuff an make it c sharp code for xml. This is my druid feral charge:

if (TargetDistance() >= 8 &&
		TargetDistance() <= 25 &&
			SpellManager.KnowSpell(16979) &&
				Rage() >= 5 &&
					SpellManager.GetSpellCooldownTimeLeft(16979) == 0)
{
	Logging.WriteFight("Casting Feral Charge (Bear Form)");
	Lua.LuaDoString(FeralCharge);
}

I've got one for warrior too, but thats also c# code. Also need something like ObjectManager.Me.HasTarget

[Garub 6]

3 hours ago, skeletonboy360 said:

Not xml, might be able to change some stuff an make it c sharp code for xml. This is my druid feral charge:

if (TargetDistance() >= 8 &&
		TargetDistance() <= 25 &&
			SpellManager.KnowSpell(16979) &&
				Rage() >= 5 &&
					SpellManager.GetSpellCooldownTimeLeft(16979) == 0)
{
	Logging.WriteFight("Casting Feral Charge (Bear Form)");
	Lua.LuaDoString(FeralCharge);
}

I've got one for warrior too, but thats also c# code. Also need something like ObjectManager.Me.HasTarget

I do not know anything about programming, but I can easily learn how to solve problems, if you can guide me, I can do the same.

[skeletonboy360 5]

Check this one. Let me know if charge works how you want it to.

test.xml

[Garub 6]

5 minutes ago, skeletonboy360 said:

Check this one. Let me know if charge works how you want it to.

test.xml

yes it worked perfectly, now how should I proceed to apply this in my Fight Class, I want to boot the same to Intercept. 
Note:we have to show this to the developer, for him to ka this by default in Wrobot.

[Garub 6]

11 minutes ago, skeletonboy360 said:

Check this one. Let me know if charge works how you want it to.

test.xml

Even though I was a layman I analyzed your code, I think I can easily edit it, I just have a question, I put the coodown in [time> spellsettings> Time] or here [SpellManager.GetSpellCooldownTimeLeft ("Charge") == 0]?

[Garub 6]

I've never been able to make the charge work out of combat, I'm frustrated,

is there any way to force the Wrobot to use the charge?

[Droidz 2742]

Hello, 

warrior charge.xml

[Garub 6]

3 hours ago, Droidz said:

Hello, 

warrior charge.xml

The file is blank, has nothing written.

[Ordush 185]

1 hour ago, Garub said:

The file is blank, has nothing written.

It certainly is not blank ?
I'll bet that you opened it with internet explorer. ?
 

<?xml version="1.0" encoding="utf-16"?>
<FightClass xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <FightClassGeneralSettings>
    <FightClassName>Fight config name</FightClassName>
	</FightClassGeneralSettings>
    <FightClassSpell>
      <FightClassConditions>
        <FightClassCondition>
          <ContionType>TargetDistance</ContionType>
          <Param xsi:type="FightClassConditionNumber">
            <Type>Bigger</Type>
            <Value>8</Value>
          </Param>
        </FightClassCondition>
      </FightClassConditions>
      <SpellName>Charge</SpellName>
      <Priority>1</Priority>
    </FightClassSpell>
</FightClass>

 

[Garub 6]

13 minutes ago, Ordush said:

It certainly is not blank ?
I'll bet that you opened it with internet explorer. ?
 

<?xml version="1.0" encoding="utf-16"?>
<FightClass xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <FightClassGeneralSettings>
    <FightClassName>Fight config name</FightClassName>
	</FightClassGeneralSettings>
    <FightClassSpell>
      <FightClassConditions>
        <FightClassCondition>
          <ContionType>TargetDistance</ContionType>
          <Param xsi:type="FightClassConditionNumber">
            <Type>Bigger</Type>
            <Value>8</Value>
          </Param>
        </FightClassCondition>
      </FightClassConditions>
      <SpellName>Charge</SpellName>
      <Priority>1</Priority>
    </FightClassSpell>
</FightClass>

 

Open in Fight Class Editor and then in NotePad ++.

I apologize for the work I'm doing to you, but I do not know how to add this to my Fight Class.xml

 

[Ordush 185]

5 minutes ago, Garub said:

Open in Fight Class Editor and then in NotePad ++.

I apologize for the work I'm doing to you, but I do not know how to add this to my Fight Class.xml

 

<FightClassSpell>
      <FightClassConditions>
        <FightClassCondition>
          <ContionType>TargetDistance</ContionType>
          <Param xsi:type="FightClassConditionNumber">
            <Type>Bigger</Type>
            <Value>8</Value>
          </Param>
        </FightClassCondition>
      </FightClassConditions>
      <SpellName>Charge</SpellName>
      <Priority>1</Priority>
    </FightClassSpell>

<FightClassSpell> means the start of a spell (charge in this case)
</FightClassSpell> means the end of a spell
So go open your fightclass with notepad, and paste the code i just added above under a </FightClassSpell>

now if you open your fightclass with the editor the spell Droidz made will be there, move it around as you like.
Also make sure you have CombatOnly turned off. Otherwise it will not work out of combat.

Edited June 15, 2018 by Ordush

[Garub 6]

11 minutes ago, Ordush said:

<FightClassSpell>
      <FightClassConditions>
        <FightClassCondition>
          <ContionType>TargetDistance</ContionType>
          <Param xsi:type="FightClassConditionNumber">
            <Type>Bigger</Type>
            <Value>8</Value>
          </Param>
        </FightClassCondition>
      </FightClassConditions>
      <SpellName>Charge</SpellName>
      <Priority>1</Priority>
    </FightClassSpell>

<FightClassSpell> means the start of a spell (charge in this case)
</FightClassSpell> means the end of a spell
So go open your fightclass with notepad, and paste the code i just added above under a </FightClassSpell>

now if you open your fightclass with the editor the spell Droidz made will be there, move it around as you like.
Also make sure you have CombatOnly turned off. Otherwise it will not work out of combat.

I just wanted the change to work when I was not in combat and when I was in combat.

My limited English is not letting me understand, it would be possible to make this modification, if not Unfortune.

Warrior_Prot_xxx.xml

[Ordush 185]

7 minutes ago, Garub said:

I just wanted the change to work when I was not in combat and when I was in combat.

My limited English is not letting me understand, it would be possible to make this modification, if not Unfortune.

Warrior_Prot_xxx.xml

I literally just told you how to make it work like that. ?

I can not edit your fightclass from here, go to your "Charge" spell, and change CombatOnly to false.
It might be called something other then CombatOnly, but it's something alike.

Also by looking at your code with notepad, i can see that you have a condition called "Me in Combat" and you have set it to false.
With this, your charge will only work when you are NOT in combat
Also you have set Target Is Player to true (So it will only work if your target is a player) As far as i know, charge is used on mobs?
Furthermore you have set it, so Charge is Lua code not a spell, however you have not written any Lua Code, so it's trying to send "Charge" as lua. This will not do anything.

Now, with all this info here, you should be able to change it so it works.

Edited June 15, 2018 by Ordush

[Garub 6]

13 hours ago, Ordush said:

I literally just told you how to make it work like that. ?

I can not edit your fightclass from here, go to your "Charge" spell, and change CombatOnly to false.
It might be called something other then CombatOnly, but it's something alike.

Also by looking at your code with notepad, i can see that you have a condition called "Me in Combat" and you have set it to false.
With this, your charge will only work when you are NOT in combat
Also you have set Target Is Player to true (So it will only work if your target is a player) As far as i know, charge is used on mobs?
Furthermore you have set it, so Charge is Lua code not a spell, however you have not written any Lua Code, so it's trying to send "Charge" as lua. This will not do anything.

Now, with all this info here, you should be able to change it so it works.

I would like to thank you for your commitment, I finally got it, everything is working right. ^^ ?

[OliZ 5]

What talents do u use? also wich stance?

[Ordush 185]

On 8/5/2023 at 10:11 AM, OliZ said:

What talents do u use? also wich stance?

This topic was last posted on 5 years ago, and apparently the user is also banned. So I don't think you will get any answer tbh. 🙂

[OliZ 5]

16 hours ago, Ordush said:

This topic was last posted on 5 years ago, and apparently the user is also banned. So I don't think you will get any answer tbh. 🙂

Oh, haha well thanks anyways! :D