Jump to content

DonaldMacRonald

Members
 View Profile  See their activity

  • Posts

    48

  • Joined

  • Last visited

 Content Type 

Everything posted by DonaldMacRonald

  1. DonaldMacRonald
    To follow the progress on Attack/AutoShot problem :
  2. DonaldMacRonald
    There you go for th fightclass :
  3. DonaldMacRonald
    Hello. That will make a lot of double posting, sorry for that, but as Eeny advise me to post here in PM. Here are the two main problems I saw concerning Attack and Auto-Shot for hunters. I suspect the problem should be the same for Wanding : Something that needs to be highlighten: I don't know for other classes since I didn't look at them in depth yet, but for Hunters, Attack spell (id:6603) is a self cast spell. That causes the toon to "loose" it's target, as the log tells it, when you go back to Ranged spells => [FIGHT] Manual target change For me that's not the solution, since it look like it's the "main entry" for combat trigger in grinder/quester. If isRepeating detection of Attack spell could be fixed, that should be enough to correct the problem. Also, inside the bot grinder/quester routines, Attack should then not be re-triggered if Auto-Shot/Wanding isRepeating and in good range. This one should also correct the rotation if isRepeating can not be fixed (at least for Hunters).
  4. DonaldMacRonald
    Something that needs to be highlighten: I don't know for other classes since I didn't look at them, but for hunters, Attack speel (6603) is a self cast spell. That causes the toon to "loose" it's target as the log tells it=> [FIGHT] Manual target change
  5. DonaldMacRonald
    A simple solution would have been to replace "Reward Item" by : WarriorRewardItem, RogueRewardItem, PriestRewardItem,... and check which class is the toon currently playing. The Quest developper then just add the Reward Item gossip for each of this variable. I know that after testing to edit the very first quest proposed in Vanilla, I don't want to hassle to make Quest profiles if I have to maintain [Number of Class] * Quests version for each class just to pin rewards correctly. Best Item addons chooser aren't accessible for all WoW versions ;)
  6. DonaldMacRonald
    Oddly, when the configuration Panels open, the current state of the file isn't correctly displayed too. Some variables are displayed false whereas they are set at true in the saved file. No correlation between default values.
  7. DonaldMacRonald
    Hello, Yes I do call Save(), at the end of the sowconfiguration, and no curiously I have no message, even in debug mode.
  8. DonaldMacRonald
    Here is an example of class I use : public class PriestSettings : Settings { [Setting] [DefaultValue(true)] [Category("Movements")] [DisplayName("Follow Mode")] [Description("Follow the party Leader. Only working when in party")] public bool FollowMode { get; set; } [Setting] [DefaultValue(80)] [Category("Heal")] [DisplayName("Lesser Heal Treshold")] [Description("Limit of Life under which bot trigger LesserHeal.In percent")] public double LesserHealTreshold { get; set; } private PriestSettings() { ConfigWinForm(new System.Drawing.Point(400, 400), "Priest " + Translate.Get("Settings")); } public static PriestSettings CurrentSetting { get; set; } public bool Save() { try { return Save(AdviserFilePathAndName("McRo-Priest", ObjectManager.Me.Name + "." + Usefuls.RealmName)); } catch (Exception e) { Logging.WriteError("PriestSettings > Save(): " + e); return false; } } public static bool Load() { try { if (File.Exists(AdviserFilePathAndName("McRo-Priest", ObjectManager.Me.Name + "." + Usefuls.RealmName))) { CurrentSetting = Load<PriestSettings>(AdviserFilePathAndName("McRo-Priest", ObjectManager.Me.Name + "." + Usefuls.RealmName)); return true; } CurrentSetting = new PriestSettings(); } catch (Exception e) { Logging.WriteError("PriestSettings > Load(): " + e); } return false; } } When trying to change a value, in the resulting XML: the value changed is never saved. If it existed in the file it is totaly deleted the value non targeted by the change may be delete also (randomly)
  9. DonaldMacRonald
    I still opened a bug because, I suppose, the fact that Attack reptition is not detected makes Grinder bot (and probably Quester too, not tested) spams Attack dumbly whatever spell you cast.
  10. DonaldMacRonald
    I opened a bug request I can't do more about it right now.
  11. DonaldMacRonald
    Hello On Grinder, whatever I do, when in combat my avatar just spam Attack. I suppose Quester will have the same problem. This might be linked to :
  12. DonaldMacRonald
    Linked to addon use. Not a bug. Can be closed.
  13. DonaldMacRonald
    Hello SpellManager.IsRepeating(Attack.Ids) on Hunter Attack spell (6603) always return false. SpellManager.IsRepeating(new List<uint>{6603}) Always return false too.
  14. DonaldMacRonald
    @Pasterke It's much more complicated than that. If you take into account Party, WRotation, Grinder, Quester, etc. logics it just can't be done that way : how do you manage the cases: where you start combat at close combat and then it goes to range combat, whatever your level is? where you're out of mana ? And range is already fixed at 35 in my figh class Furthermore, in Grinder for exemple Serpent Sting does trigger Auto Shot but it is immediatly overriden by Attack command which is spammed by the Grind bot @MacPod I didn't test my fight classes against Grinder nor Quester yet. I'm actually working on it, but it's gonna be a bit tougher since Grinder bot spams Attack command .... I strongly believe it's because the bot is faulty on Hunter Attack. It can't detect, in C# if it is triggered or not.
  15. DonaldMacRonald
    By the way , is there any function to actually set a target without interacting with it ?
  16. DonaldMacRonald
    You'll find "Launch rotation when combat start" when you select Wrotation product, and you click on Product Settings
  17. DonaldMacRonald
    Try my new version. I just uploaded a new one which should work. Follow the instructions in the description page
  18. DonaldMacRonald
    OK !!!!!!!!!!!!!!!!!!!! I finally found the bloody solution : The problems : Hunter Attack spell is cast on SELF (So when you cast Attack you target yourself => Manual Target change ... Doh ! And you leave combat mode... but not your target if you hit it) AND When you don't have target GetDistance functions gives insane results (distance >6000 for the record distance of sight is 100) AND There's no way to know if Hunter Attack is repeating Solution: So the point is to manage to save the target at start of the fight (if ranged). Then when target change, mostly because you're getting in close combat mode, (you leave combat) you test if your old target is dead. If no => get target and Attack again The surprise is that your "not new" target is not in SpellRange => Distance : more than 6600 o_O Well sorry ... I can't explain better in english... Here is the code solution (tested on newbie and lvl 16 char to be sure): McRo Hunter.cs Drawback : You must : - check "Launch rotation when combat start" if you want to use right mouse click but you'll attack every Hostile targets. Should be used only by hunters lvl <10 not having pets - start combat manually with auto Shot - have your pet on defensive (will attack first and then trigger combat routine) McRo Hunter.cs
  19. DonaldMacRonald
    I am cuurently working on it. It's also a bug that annoying me a lot, Hunter being my favorite class
  20. DonaldMacRonald
    Hello that doesn't help. Auto Shot trigger works OK But I'm noticying that : SpellManager.IsRepeating(Attack.Ids) always return false (even when Attack is on). even SpellManager.IsRepeating(new List<uint> { 6603 }) 6603 being Hunter Attack SpellID (from what wrobot is displaying) no more chances with Lua.LuaDoString<bool>("return IsAutoRepeatAction(" + (SpellManager.GetSpellSlotId(SpellListManager.SpellIdByName("Attack")) + 1) + ")"); (<= by the way it doesn't add +1 it concatenates inside of LuaDoString) I tried to add Thread.Sleep(Usefuls.Latency + 2000); but doesn't help either Anyway before reaching Attack test trigger toon should go throught Raptor Strike test, and it doesn't reach it. The "Manual target change" disable combat state That's when I start combat with right mouse click. Starting it with direct press on Auto shot, the bot stay in combat as long as it is in Ranged combat distance. Once in Close combat it activates Raptor strike, then directly, Attack and => Manual target change [EDIT] OK I think I've got what's going on look at spell definition : http://db.vanillagaming.org/?spell=6603 It's cast on SELF. That's why there's a manual target change
  21. DonaldMacRonald
    This link to xml made throught Fight Class creator but in pur C# it is not relevant. I have the exact same problem with hunter, and casters with wand. Here is what I do but, it's not working : //Auto Shot if (!SpellManager.IsRepeating(AutoShot.Ids) && AutoShot.IsDistanceGood) { AutoShot.Launch(); return; } //Attack if (!SpellManager.IsRepeating(Attack.Ids) && Attack.IsDistanceGood) { Attack.Launch(); return; } At the end of the first pass in Combat routine I see [Fight] Manually target change If target stay in AUto Shot range (higher than 8 Yards) Auto Shot is retriggered If target come to close combat range my target is still highlighted but but my toon drops combat state and stay still until he dies. McRo Hunter.cs
  22. DonaldMacRonald
    Ok I'm a dumb... I didn't launch Load function during Initialisation....
  23. DonaldMacRonald

    Version 1.0.0

    572 downloads

    WORK IN PROGRESS (currently supports spell 0 -> 10)! You can use it past this level but newer active abilities won't be used Hello fellow rogue! This is a basic C# Fight class for Rogue. Tested and working in Party mode and WRotation What it does : Attack Sinister Strike Eviscerate ( when 3 combo) Stealth Deadly Poison (UNTESTED) Sprint (UNTESTED) Kown Issues: Stealth doesn't work (need to work on logic) To Do: add new spells add Talents management enhance the logic add racials [MAYBE] add a target manager [MAYBE] add a movement/following party manager Notes : If you plan to use it with WRotation I strongly recommend you to disable "Product Settings > Manage character movement" May the light be with you!
  24. DonaldMacRonald

    Version 1.0.0

    491 downloads

    WORK IN PROGRESS (currently supports spell 0 -> 10)! You can use it past this level but newer active abilities won't be used Hello fellow warrior! This is a basic C# Fight class for Warriors. Tested and working in Party mode and WRotation What it does : Attack Heroic Strike Rend Charge Sunder Armor Taunt Kown Issues: Not compatible with use of : pfui addon To Do: add a target manager add group spell management (taunt management basically) add new spells add Talents management enhance the logic [MAYBE] add a movement/following party manager Notes : If you plan to use it with WRotation I strongly recommend you to disable "Product Settings > Manage character movement" Happy crushing !
  25. DonaldMacRonald

    Version 1.0.0

    458 downloads

    WORK IN PROGRESS (currently supports spell 0 -> 10)! You can use it past this level but newer active abilities won't be used Hello fellow paladin! This is a basic C# Fight class for Paladin. Tested and working in Party mode (Don't put "heal setting" on) and WRotation What it does : Attack Seal of Righteousness Blessing Of Might Hammer of Justice Holy Light (if you're below 80% health) Judgement (on Seal of Righteousness) Action below are added when you're in a party: Holy Light on party members (if they are below 80% health) Devotion Aura Kown Issues: ... To Do: add new spells add Talents management enhance the logic [MAYBE] add a target manager [MAYBE] add a movement/following party manager Notes : I reuse some of Cindarella code If you plan to use it with WRotation I strongly recommend you to disable "Product Settings > Manage character movement" May the light be with you!
×
×
  • Create New...