I am writing a fight class in C# and got it to cast revive on dead party members but it will spam it.

This is what I used

Quote

                                if (p.IsValid && p.IsDead)
                                {
                                    SpellManager.CastSpellByNameOn("Revive", p.Name);
                                    Usefuls.WaitIsCasting();
                                 }

Btw, huge thanks to @Sye for taking his time to show me around on how to write a fight class in C# I am very grateful

Use a timer you set when using SpellManager.CastSpellByName and add to the condiiton that the timer needs to be ready
Edit: Ideally you want one timer per unit guid you tried to rezz

Edited May 18, 20205 yr by Matenia

@Matenia May I ask why a timer? I’ve always found waitiscasting to be the best way

Because you don´t have a cooldown on your revive ability and usefuls.waitiscast just wait until the Cast is done. So when the target don´t accept the ressurrection immediatly he get´s spammed over and over again. Therefore just use a timer for each target you already casted revive on, so it won´t spam revive on the same target again and again.

Blacklist the target for an amount of time after use and use the !Blacklisted to cast on others.

@Talamin interesting, isn’t there a lua bool to check of a toon was recently rezzed??

46 minutes ago, Sye said:

@Talamin interesting, isn’t there a lua bool to check of a toon was recently rezzed??

no

 

Hey, does anyone know how to revive a player who has already released spirit?

using Timer = robotManager.Helpful.Timer;

public Spell rezz = new Spell("revive");

if (p.IsDead && ObjectManager.Me.IsAlive && !Fight.InFight && _time.IsReady)
                                    {
                                        if (ObjectManager.Me.Target != p.Guid)
                                            Interact.InteractGameObject(p.GetBaseAddress);
                                        rezz.Launch();
                                        Usefuls.WaitIsCasting();
                                        _time.Reset();

                                    }

I helped him,

I mean revive player by his empty corpse 

Get corpses from objectmanager instead of wowunit or wowplayer

https://marsbars.gitlab.io/unoffical-wrobot-api-docs/api/wManager.Wow.ObjectManager.WoWCorpse.html

Works, thanks

 

                var corpse = ObjectManager.GetObjectWoWCorpse().FirstOrDefault();
                if (corpse.IsValid)
                {
                    Lua.LuaDoString("print('corpse exists, name: ["+corpse.Name+"], guid: ["+corpse.Guid+"], baseadress: ["+corpse.GetBaseAddress+"]')");
                    SpellManager.CastSpellByNameLUA("Revive");
                    Interact.InteractGameObject(corpse.GetBaseAddress);
                }

 

You may want to interact with corpse before casting.

1 hour ago, Sye said:

You may want to interact with corpse before casting.

You can't interact with released corpses

You may need to do some testing with the offsets found Here

 

@iMod used "uint mouseOverGUID = 0x00BD07A0;"

or 

@Droidz used "uint s_MouseOver = 0x00BD0798;"

other offsets

He already posted a method that works?

yes but this method uses mouseover instead of using interact with a corpse. 

13 hours ago, Sye said:

This should work (untested)

 

using System;
using System.Linq;
using wManager.Wow;
using wManager.Wow.Helpers;
using wManager.Wow.ObjectManager;
using Timer = robotManager.Helpful.Timer;




    public static class untested
{
    public static Timer _time = new Timer(5000);

    public static void Revive(string spellname, int vector)
    {
        var corpse = ObjectManager.GetObjectWoWCorpse().FirstOrDefault(o => o.Name == o.Name && o.Position.DistanceTo(ObjectManager.Me.Position) < vector);
        uint mouseover = 0x00BD07A0;
        if (_time.IsReady)
        {
            Memory.WowMemory.Memory.WriteUInt64(mouseover, corpse.Guid);
            SpellManager.CastSpellByNameOn(spellname, "mouseover");
            Usefuls.WaitIsCasting();
            ObjectManager.BlackListGetUnitAttackPlayerGuidTime.Add(corpse.Guid, DateTime.Now + TimeSpan.FromMinutes(1));
            _time.Reset();
        }
    }
}

use this to call for it in your fightclass 

untested.Revive("Spellname", 25);

 

your code is illogical, mouseover is in wrobot API you don't need to write in memory manually, why do "o.Name == o.Name" ? Why blacklist corpse in blacklist for hostile unit? (and search corpse without check if corpse is in this blacklist). 
It's nice to help, but this type of code can mislead users.

 

 

Code (not tested) with target should look like:

var revive = new Spell("Revive", false);
if (Conditions.InGameAndConnectedAndAliveAndProductStartedNotInPause && !ObjectManager.Me.IsCast && revive.KnownSpell && revive.IsSpellUsable)
{
    var corpse = ObjectManager.GetObjectWoWCorpse().Where(c => !wManager.wManagerSetting.IsBlackListed(c.Guid)).FirstOrDefault();
    if (corpse != null && corpse.IsValid)
    {
        Interact.ClearTarget(); // or  Interact.InteractGameObject(corpse.GetBaseAddress);
        revive.Launch();
        Interact.InteractGameObject(corpse.GetBaseAddress);
        wManager.wManagerSetting.AddBlackList(corpse.Guid, 1000 * 60 * 10);
    }
}

with focus should look like:

var revive = new Spell("Revive", false);
if (Conditions.InGameAndConnectedAndAliveAndProductStartedNotInPause && !ObjectManager.Me.IsCast && revive.KnownSpell && revive.IsSpellUsable)
{
    var corpse = ObjectManager.GetObjectWoWCorpse().Where(c => !wManager.wManagerSetting.IsBlackListed(c.Guid)).FirstOrDefault();
    if (corpse != null && corpse.IsValid)
    {
        var old = ObjectManager.Me.FocusGuid;
        ObjectManager.Me.FocusGuid = corpse.Guid;
        revive.Launch(true, true, false, "focus");
        ObjectManager.Me.FocusGuid = old;
        wManager.wManagerSetting.AddBlackList(corpse.Guid, 1000 * 60 * 10);
    }
}